From: Nadav Har'El <nyh@math.technion.ac.il>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
avi.kivity@gmail.com
Subject: Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state
Date: Sat, 23 Feb 2013 23:45:03 +0200 [thread overview]
Message-ID: <20130223214503.GA13800@fermat.math.technion.ac.il> (raw)
In-Reply-To: <5129361A.7090608@web.de>
On Sat, Feb 23, 2013, Jan Kiszka wrote about "[PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state":
> - kvm_set_cr0(vcpu, vmcs12->host_cr0);
> + vmx_set_cr0(vcpu, vmcs12->host_cr0);
I don't remember now why I did this (and I'm not looking at the code),
but this you'll need to really test carefully, including
shadow-on-shadow mode (ept=0 in L0), to verify you're not missing any
important side-effect of kvm_set_cr0.
Also, if I remember correctly, during nVMX's review, Avi Kivity asked
in several places that when I called vmx_set_cr0, I should instead call
kvm_set_cr0(), because it does some extra stuff and does some extra
checks. Hmm, see, see this:
http://markmail.org/message/hhidqyhbo2mrgxxc
where Avi asked for the reverse patch you're attempting now.
--
Nadav Har'El | Saturday, Feb 23 2013, 14 Adar 5773
nyh@math.technion.ac.il |-----------------------------------------
Phone +972-523-790466, ICQ 13349191 |It is better to be thought a fool, then
http://nadav.harel.org.il |to open your mouth and remove all doubt.
next prev parent reply other threads:[~2013-02-23 21:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-23 21:35 [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state Jan Kiszka
2013-02-23 21:45 ` Nadav Har'El [this message]
2013-02-23 21:57 ` Jan Kiszka
2013-02-23 22:21 ` Jan Kiszka
2013-02-24 8:34 ` Jan Kiszka
2013-02-24 8:56 ` Avi Kivity
2013-02-24 9:01 ` Jan Kiszka
2013-02-24 9:21 ` Avi Kivity
2013-02-24 9:40 ` Jan Kiszka
2013-02-24 10:11 ` Avi Kivity
2013-02-24 10:49 ` Jan Kiszka
2013-02-24 18:56 ` Avi Kivity
2013-02-24 19:15 ` Jan Kiszka
2013-02-24 19:26 ` Avi Kivity
2013-04-28 10:20 ` Jan Kiszka
2013-04-30 11:46 ` Gleb Natapov
2013-04-30 12:42 ` Jan Kiszka
2013-05-05 9:02 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223214503.GA13800@fermat.math.technion.ac.il \
--to=nyh@math.technion.ac.il \
--cc=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox