From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [RFC PATCH v2 2/4] KVM: Introduce KVM_CSS_BUS.
Date: Mon, 25 Feb 2013 09:50:34 +0100 [thread overview]
Message-ID: <20130225095034.776c8824@gondolin> (raw)
In-Reply-To: <20130224095725.GF25269@redhat.com>
On Sun, 24 Feb 2013 11:57:25 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Feb 22, 2013 at 01:09:47PM +0100, Cornelia Huck wrote:
> > Add a new bus type for s390 css kvm io devices.
> >
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > ---
> > include/linux/kvm_host.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index 3b768ef..59be516 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -148,6 +148,7 @@ struct kvm_io_bus {
> > enum kvm_bus {
> > KVM_MMIO_BUS,
> > KVM_PIO_BUS,
> > + KVM_CSS_BUS,
>
> so maybe KVM_S390_VIRTIO_CCW_NOTIFY_BUS
>
> to make the fact it's s390 and virtio specific, explicit?
Hm, I don't really see a need to point out that this is s390-specific,
so I think I'd prefer KVM_VIRTIO_CCW_NOTIFY_BUS.
>
> > KVM_NR_BUSES
> > };
> >
> > --
> > 1.7.12.4
>
next prev parent reply other threads:[~2013-02-25 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 12:09 [RFC PATCH v2 0/4] kvm: Make ioeventfd usable on s390 Cornelia Huck
2013-02-22 12:09 ` [RFC PATCH v2 1/4] KVM: Initialize irqfd from kvm_init() Cornelia Huck
2013-02-22 12:09 ` [RFC PATCH v2 2/4] KVM: Introduce KVM_CSS_BUS Cornelia Huck
2013-02-24 9:57 ` Michael S. Tsirkin
2013-02-25 8:50 ` Cornelia Huck [this message]
2013-02-22 12:09 ` [RFC PATCH v2 3/4] KVM: ioeventfd for s390 css devices Cornelia Huck
2013-02-24 9:47 ` Michael S. Tsirkin
2013-02-25 8:49 ` Cornelia Huck
2013-02-22 12:09 ` [RFC PATCH v2 4/4] KVM: s390: Wire up ioeventfd Cornelia Huck
2013-02-24 9:45 ` Michael S. Tsirkin
2013-02-25 8:46 ` Cornelia Huck
2013-02-24 9:40 ` [RFC PATCH v2 0/4] kvm: Make ioeventfd usable on s390 Michael S. Tsirkin
2013-02-24 9:56 ` Michael S. Tsirkin
2013-02-25 8:43 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225095034.776c8824@gondolin \
--to=cornelia.huck@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox