From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [RFC PATCH v2 2/4] KVM: Introduce KVM_CSS_BUS. Date: Mon, 25 Feb 2013 09:50:34 +0100 Message-ID: <20130225095034.776c8824@gondolin> References: <1361534989-38884-1-git-send-email-cornelia.huck@de.ibm.com> <1361534989-38884-3-git-send-email-cornelia.huck@de.ibm.com> <20130224095725.GF25269@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: KVM , linux-s390 , qemu-devel To: "Michael S. Tsirkin" Return-path: Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:57540 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757703Ab3BYIum (ORCPT ); Mon, 25 Feb 2013 03:50:42 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Feb 2013 08:48:37 -0000 In-Reply-To: <20130224095725.GF25269@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 24 Feb 2013 11:57:25 +0200 "Michael S. Tsirkin" wrote: > On Fri, Feb 22, 2013 at 01:09:47PM +0100, Cornelia Huck wrote: > > Add a new bus type for s390 css kvm io devices. > > > > Signed-off-by: Cornelia Huck > > --- > > include/linux/kvm_host.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 3b768ef..59be516 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -148,6 +148,7 @@ struct kvm_io_bus { > > enum kvm_bus { > > KVM_MMIO_BUS, > > KVM_PIO_BUS, > > + KVM_CSS_BUS, > > so maybe KVM_S390_VIRTIO_CCW_NOTIFY_BUS > > to make the fact it's s390 and virtio specific, explicit? Hm, I don't really see a need to point out that this is s390-specific, so I think I'd prefer KVM_VIRTIO_CCW_NOTIFY_BUS. > > > KVM_NR_BUSES > > }; > > > > -- > > 1.7.12.4 >