From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: [PATCH qemu-kvm] virtfs-proxy: fix build with F18 Date: Thu, 28 Feb 2013 09:00:47 +0200 Message-ID: <20130228070047.GA22780@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Aneesh Kumar K.V" To: kvm@vger.kernel.org, gleb@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332Ab3B1HAf (ORCPT ); Thu, 28 Feb 2013 02:00:35 -0500 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Ignoring return value of setfsgid(gid) and setfsuid(uid) causes warnings on F18. Check the return value: man page says glibc returns -1 on error. Signed-off-by: Michael S. Tsirkin --- fsdev/virtfs-proxy-helper.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index f9a8270..2f0d2b3 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -282,6 +282,7 @@ static int send_status(int sockfd, struct iovec *iovec, int status) */ static int setfsugid(int uid, int gid) { + int ret; /* * We still need DAC_OVERRIDE because we don't change * supplementary group ids, and hence may be subjected DAC rules @@ -290,8 +291,10 @@ static int setfsugid(int uid, int gid) CAP_DAC_OVERRIDE, }; - setfsgid(gid); - setfsuid(uid); + ret = setfsgid(gid); + assert(ret != -1); + ret = setfsuid(uid); + assert(ret != -1); if (uid != 0 || gid != 0) { return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0); -- MST