From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
"Nadav Har'El" <nyh@math.technion.ac.il>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH] KVM: nVMX: Avoid one redundant vmcs_read in prepare_vmcs12
Date: Thu, 28 Feb 2013 10:20:19 +0200 [thread overview]
Message-ID: <20130228082019.GQ23616@redhat.com> (raw)
In-Reply-To: <5124C95F.1090704@siemens.com>
On Wed, Feb 20, 2013 at 02:02:23PM +0100, Jan Kiszka wrote:
> IDT_VECTORING_INFO_FIELD was already read right after vmexit.
>
Applied, thanks.
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> arch/x86/kvm/vmx.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 7d2fbd2..d99a519 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7368,8 +7368,7 @@ void prepare_vmcs12(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>
> vmcs12->vm_exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
> vmcs12->vm_exit_intr_error_code = vmcs_read32(VM_EXIT_INTR_ERROR_CODE);
> - vmcs12->idt_vectoring_info_field =
> - vmcs_read32(IDT_VECTORING_INFO_FIELD);
> + vmcs12->idt_vectoring_info_field = to_vmx(vcpu)->idt_vectoring_info;
> vmcs12->idt_vectoring_error_code =
> vmcs_read32(IDT_VECTORING_ERROR_CODE);
> vmcs12->vm_exit_instruction_len = vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
> --
> 1.7.3.4
--
Gleb.
prev parent reply other threads:[~2013-02-28 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 13:02 [PATCH] KVM: nVMX: Avoid one redundant vmcs_read in prepare_vmcs12 Jan Kiszka
2013-02-28 8:20 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228082019.GQ23616@redhat.com \
--to=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nyh@math.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox