From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] KVM: nVMX: Avoid one redundant vmcs_read in
 prepare_vmcs12
Date: Thu, 28 Feb 2013 10:20:19 +0200
Message-ID: <20130228082019.GQ23616@redhat.com>
References: <5124C95F.1090704@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
	"Nadav Har'El" <nyh@math.technion.ac.il>,
	"Nakajima, Jun" <jun.nakajima@intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34346 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751192Ab3B1IU3 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 28 Feb 2013 03:20:29 -0500
Content-Disposition: inline
In-Reply-To: <5124C95F.1090704@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Feb 20, 2013 at 02:02:23PM +0100, Jan Kiszka wrote:
> IDT_VECTORING_INFO_FIELD was already read right after vmexit.
> 
Applied, thanks.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  arch/x86/kvm/vmx.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 7d2fbd2..d99a519 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7368,8 +7368,7 @@ void prepare_vmcs12(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>  
>  	vmcs12->vm_exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
>  	vmcs12->vm_exit_intr_error_code = vmcs_read32(VM_EXIT_INTR_ERROR_CODE);
> -	vmcs12->idt_vectoring_info_field =
> -		vmcs_read32(IDT_VECTORING_INFO_FIELD);
> +	vmcs12->idt_vectoring_info_field = to_vmx(vcpu)->idt_vectoring_info;
>  	vmcs12->idt_vectoring_error_code =
>  		vmcs_read32(IDT_VECTORING_ERROR_CODE);
>  	vmcs12->vm_exit_instruction_len = vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
> -- 
> 1.7.3.4

--
			Gleb.