public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: KVM: x86: Racy mp_state manipulations
Date: Tue, 5 Mar 2013 09:28:20 +0200	[thread overview]
Message-ID: <20130305072820.GU23616@redhat.com> (raw)
In-Reply-To: <5134ABDD.4090908@redhat.com>

On Mon, Mar 04, 2013 at 03:12:45PM +0100, Paolo Bonzini wrote:
> The latter makes sense since it's not a fast path, but the only
> transition that is acceptable to KVM_MP_STATE_HALTED is from
> KVM_MP_STATE_RUNNABLE:
> 
> from \ to    RUNNABLE     UNINIT      INIT     HALTED       SIPI
> RUNNABLE       n/a          yes        yes       yes         NO
> UNINIT         NO           n/a        yes       NO          NO
> INIT           NO           yes        n/a       NO          yes
> HALTED         yes          yes        yes       n/a         NO
> SIPI           yes          yes        yes       NO          n/a
> 
About UNINIT column. It should be NO for all of them. vcpu enters UNINIT
state only after creation and never returns to it.

--
			Gleb.

      parent reply	other threads:[~2013-03-05  7:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-03 16:48 KVM: x86: Racy mp_state manipulations Jan Kiszka
2013-03-04 14:12 ` Paolo Bonzini
2013-03-04 14:28   ` Jan Kiszka
2013-03-04 15:08     ` Paolo Bonzini
2013-03-04 15:19       ` Jan Kiszka
2013-03-05  7:28   ` Gleb Natapov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130305072820.GU23616@redhat.com \
    --to=gleb@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox