From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
"Nadav Har'El" <nyh@math.technion.ac.il>
Subject: Re: [PATCH v2] KVM: nVMX: Fix setting of CR0 and CR4 in guest mode
Date: Wed, 6 Mar 2013 21:33:52 -0300 [thread overview]
Message-ID: <20130307003352.GA29343@amt.cnet> (raw)
In-Reply-To: <5134F8AD.8030607@web.de>
On Mon, Mar 04, 2013 at 08:40:29PM +0100, Jan Kiszka wrote:
> The logic for calculating the value with which we call kvm_set_cr0/4 was
> broken (will definitely be visible with nested unrestricted guest mode
> support). Also, we performed the check regarding CR0_ALWAYSON too early
> when in guest mode.
>
> What really needs to be done on both CR0 and CR4 is to mask out L1-owned
> bits and merge them in from GUEST_CR0/4. In contrast, arch.cr0/4 and
> arch.cr0/4_guest_owned_bits contain the mangled L0+L1 state and, thus,
> are not suited as input.
>
> For both CRs, we can then apply the check against VMXON_CRx_ALWAYSON and
> refuse the update if it fails. To be fully consistent, we implement this
> check now also for CR4.
>
> Finally, we have to set the shadow to the value L2 wanted to write
> originally.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied, thanks.
next prev parent reply other threads:[~2013-03-07 0:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 19:40 [PATCH v2] KVM: nVMX: Fix setting of CR0 and CR4 in guest mode Jan Kiszka
2013-03-05 12:57 ` Gleb Natapov
2013-03-05 13:02 ` Gleb Natapov
2013-03-05 13:18 ` Jan Kiszka
2013-03-07 0:33 ` Marcelo Tosatti [this message]
2013-03-07 7:51 ` Gleb Natapov
2013-03-07 8:12 ` Jan Kiszka
2013-03-07 8:27 ` Jan Kiszka
2013-03-07 8:48 ` Gleb Natapov
2013-03-07 8:43 ` Gleb Natapov
2013-03-07 8:53 ` Jan Kiszka
2013-03-07 8:57 ` Gleb Natapov
2013-03-07 10:37 ` Jan Kiszka
2013-03-07 11:06 ` Gleb Natapov
2013-03-07 11:25 ` Jan Kiszka
2013-03-07 11:50 ` Gleb Natapov
2013-03-07 11:57 ` Jan Kiszka
2013-03-07 12:05 ` Gleb Natapov
2013-03-07 12:18 ` Jan Kiszka
2013-03-07 12:21 ` Gleb Natapov
2013-03-07 12:48 ` Jan Kiszka
2013-03-07 13:04 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307003352.GA29343@amt.cnet \
--to=mtosatti@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=nyh@math.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox