public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Yang Zhang <yang.z.zhang@intel.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com,
	xiantao.zhang@intel.com, hpa@linux.intel.com
Subject: Re: [PATCH v5 2/5] KVM: VMX: Register a new IPI for posted interrupt
Date: Fri, 8 Mar 2013 14:26:25 +0100	[thread overview]
Message-ID: <20130308132625.GA27750@gmail.com> (raw)
In-Reply-To: <1362705801-4467-3-git-send-email-yang.z.zhang@intel.com>


* Yang Zhang <yang.z.zhang@intel.com> wrote:

> diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
> index 6e03b0d..2329a54 100644
> --- a/arch/x86/kernel/irqinit.c
> +++ b/arch/x86/kernel/irqinit.c
> @@ -205,6 +205,10 @@ static void __init apic_intr_init(void)
>  
>  	/* IPI for X86 platform specific use */
>  	alloc_intr_gate(X86_PLATFORM_IPI_VECTOR, x86_platform_ipi);
> +#ifdef CONFIG_HAVE_KVM
> +	/* IPI for KVM to deliver posted interrupt */
> +	alloc_intr_gate(POSTED_INTR_VECTOR, kvm_posted_intr_ipi);
> +#endif

Please avoid wasting an IDT entry by reusing x86_platform_ipi.

A KVM guest is in essence one type of 'x86 platform', and this callback is used by 
hardware platforms, so collision is not an issue AFAICS.

Thanks,

	Ingo

  reply	other threads:[~2013-03-08 13:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08  1:23 [PATCH v5 0/5] KVM: VMX: Add Posted Interrupt supporting Yang Zhang
2013-03-08  1:23 ` [PATCH v5 1/5] KVM: VMX: Enable acknowledge interupt on vmexit Yang Zhang
2013-03-08  1:23 ` [PATCH v5 2/5] KVM: VMX: Register a new IPI for posted interrupt Yang Zhang
2013-03-08 13:26   ` Ingo Molnar [this message]
2013-03-08 13:47     ` Gleb Natapov
2013-03-08 14:05       ` Ingo Molnar
2013-03-08 14:07         ` Zhang, Yang Z
2013-03-08 14:21         ` Gleb Natapov
2013-03-08 15:40           ` Ingo Molnar
2013-03-15  2:41             ` Zhang, Yang Z
2013-03-08  1:23 ` [PATCH v5 3/5] KVM: VMX: Check the posted interrupt capability Yang Zhang
2013-03-08  1:23 ` [PATCH v5 4/5] KVM: VMX: Add the algorithm of deliver posted interrupt Yang Zhang
2013-03-08 20:21   ` Marcelo Tosatti
2013-03-09  1:19     ` Zhang, Yang Z
2013-03-08  1:23 ` [PATCH v5 5/5] KVM : VMX: Use posted interrupt to deliver virtual interrupt Yang Zhang
2013-03-08 20:23   ` Marcelo Tosatti
2013-03-09  1:19     ` Zhang, Yang Z
2013-03-11 13:04   ` Gleb Natapov
2013-03-11 13:38     ` Zhang, Yang Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130308132625.GA27750@gmail.com \
    --to=mingo@kernel.org \
    --cc=gleb@redhat.com \
    --cc=hpa@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=xiantao.zhang@intel.com \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox