From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] KVM: x86: Convert INIT and SIPI signals into
 synchronously handled events
Date: Tue, 12 Mar 2013 15:52:14 +0200
Message-ID: <20130312135214.GF11223@redhat.com>
References: <513F1529.3040309@siemens.com>
 <20130312131211.GB11223@redhat.com>
 <513F2BCD.5040405@siemens.com>
 <20130312134145.GE11223@redhat.com>
 <513F310A.40700@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:60251 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753611Ab3CLNwR (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 Mar 2013 09:52:17 -0400
Content-Disposition: inline
In-Reply-To: <513F310A.40700@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Mar 12, 2013 at 02:43:38PM +0100, Paolo Bonzini wrote:
> Il 12/03/2013 14:41, Gleb Natapov ha scritto:
> > Not sure I understand. I am saying the code should be:
> > 
> > if (test_and_clear_bit(KVM_APIC_INIT, &apic->pending_events)) {
> > 	vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
> > 	kvm_lapic_reset(vcpu);
> > 	kvm_vcpu_reset(vcpu);
> > }
> > if (test_and_clear_bit(KVM_APIC_SIPI, &apic->pending_events) &&
> > 		vcpu->arch.mp_state == KVM_MP_STATE_INIT_RECEIVED) {
> > 	vcpu->arch.sipi_vector = apic->sipi_vector;
> > }
> > 
> 
> Yes, this is also discussed in the async_pf thread.  But kvm_vcpu_reset
> is what sets CS based on the sipi_vector, so some more changes are
> needed (or you can just reset the VCPU twice, but that's ugly...).
> 
Ah correct. We can start from reseting twice and documenting why are we
doing it. Then we should move sregs register initialization to common
code and factor out CS handling in separate function which will be
called on SIPI. Or just call kvm_set_segment() on SIPI.

--
			Gleb.