From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v2] KVM: x86: Rework INIT and SIPI handling
Date: Wed, 13 Mar 2013 23:10:16 -0300
Message-ID: <20130314021016.GA16585@amt.cnet>
References: <5140662A.7010209@siemens.com>
 <20130314000850.GA4499@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:19102 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932565Ab3CNCKm (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 13 Mar 2013 22:10:42 -0400
Content-Disposition: inline
In-Reply-To: <20130314000850.GA4499@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> vmx_vcpu_reset overwrites vcpu->srcu_idx if ->vcpu_reset is called from
> within srcu section.
> 
> Also, this is not part of the hotpath and therefore it could be farther
> from vcpu_enter_guest. What about processing a new request bit here?
> (KVM_REQ_EVENT <-> apic->pending_events relationship is cloudy).
> 
> Also the fact kvm_apic_accept_events() is called from  sites is annoying,
> why is that necessary again?

multiple sites. would be nicer if from one call site.