Re: [PATCH] KVM: nVMX: Add preemption timer support

Jan Kiszka
2013-03-13T15:01:08Z

On 2013-03-13 15:50, Jan Kiszka wrote:
> On 2013-03-13 15:44, Gleb Natapov wrote:
>> On Wed, Mar 13, 2013 at 11:31:24AM +0100, Jan Kiszka wrote:
>>> Provided the host has this feature, it's straightforward to offer it to
>>> the guest as well. We just need to load to timer value on L2 entry if
>>> the feature was enabled by L1 and watch out for the corresponding exit
>>> reason.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> arch/x86/include/asm/vmx.h | 3 +++
>>> arch/x86/include/uapi/asm/vmx.h | 5 +++--
>>> arch/x86/kvm/vmx.c | 17 ++++++++++++++---
>>> 3 files changed, 20 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
>>> index 056bda5..fc1c313 100644
>>> --- a/arch/x86/include/asm/vmx.h
>>> +++ b/arch/x86/include/asm/vmx.h
>>> @@ -70,6 +70,7 @@
>>> #define PIN_BASED_EXT_INTR_MASK 0x00000001
>>> #define PIN_BASED_NMI_EXITING 0x00000008
>>> #define PIN_BASED_VIRTUAL_NMIS 0x00000020
>>> +#define PIN_BASED_VMX_PREEMPTION_TIMER 0x00000040
>>>
>>> #define PIN_BASED_ALWAYSON_WITHOUT_TRUE_MSR 0x00000016
>>>
>>> @@ -95,6 +96,7 @@
>>>
>>> #define VM_ENTRY_ALWAYSON_WITHOUT_TRUE_MSR 0x000011ff
>>>
>>> +#define VMX_MISC_PREEMPTION_TIMER_RATE_MASK 0x0000001f
>>> #define VMX_MISC_SAVE_EFER_LMA 0x00000020
>> What is this patch against? I do not see VMX_MISC_SAVE_EFER_LMA in
>> kvm.git queue.
>
> Against my queue after adding support for nested EFER.LMA saving, sorry.
> I thought I posted that patch already, but I didn't. Will reorder (and
> send those other bits as well at that chance).

In fact, the other way around is simpler: posting the missing patch.

Jan

--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux