From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: VMX: Do not overwrite vcpu->srcu_idx in vmx_vcpu_reset
Date: Thu, 14 Mar 2013 17:02:26 -0300 [thread overview]
Message-ID: <20130314200226.GA9324@amt.cnet> (raw)
In-Reply-To: <514222FA.9060706@siemens.com>
On Thu, Mar 14, 2013 at 08:20:26PM +0100, Jan Kiszka wrote:
> >> Not sure this is valid.
> >
> > The lock/unlocks must be paired.
>
> Did you find out more than what Paolo reported?
/**
* srcu_read_unlock - unregister a old reader from an SRCU-protected
* structure.
* @sp: srcu_struct in which to unregister the old reader.
* @idx: return value from corresponding srcu_read_lock().
*
* Exit an SRCU read-side critical section.
*/
static inline void srcu_read_unlock(struct srcu_struct *sp, int idx)
__releases(sp)
{
rcu_lock_release(&(sp)->dep_map);
__srcu_read_unlock(sp, idx);
}
prev parent reply other threads:[~2013-03-14 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 14:52 [PATCH] KVM: VMX: Do not overwrite vcpu->srcu_idx in vmx_vcpu_reset Jan Kiszka
2013-03-14 15:00 ` Gleb Natapov
2013-03-14 15:03 ` Jan Kiszka
2013-03-14 15:08 ` Paolo Bonzini
2013-03-14 15:11 ` Gleb Natapov
2013-03-14 15:45 ` Paolo Bonzini
2013-03-14 15:11 ` Jan Kiszka
2013-03-14 19:14 ` Marcelo Tosatti
2013-03-14 19:20 ` Jan Kiszka
2013-03-14 19:39 ` [PATCH v2] " Jan Kiszka
2013-03-15 7:09 ` Jan Kiszka
2013-03-14 20:02 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314200226.GA9324@amt.cnet \
--to=mtosatti@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox