From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: VMX: Do not overwrite vcpu->srcu_idx in
 vmx_vcpu_reset
Date: Thu, 14 Mar 2013 17:02:26 -0300
Message-ID: <20130314200226.GA9324@amt.cnet>
References: <5141E41B.8080804@siemens.com>
 <20130314150004.GX11223@redhat.com>
 <20130314191438.GA9009@amt.cnet>
 <514222FA.9060706@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49649 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751081Ab3CNVGh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 14 Mar 2013 17:06:37 -0400
Content-Disposition: inline
In-Reply-To: <514222FA.9060706@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Mar 14, 2013 at 08:20:26PM +0100, Jan Kiszka wrote:
> >> Not sure this is valid.
> > 
> > The lock/unlocks must be paired.
> 
> Did you find out more than what Paolo reported?

/**
 * srcu_read_unlock - unregister a old reader from an SRCU-protected
 * structure.
 * @sp: srcu_struct in which to unregister the old reader.
 * @idx: return value from corresponding srcu_read_lock().
 *
 * Exit an SRCU read-side critical section.
 */
static inline void srcu_read_unlock(struct srcu_struct *sp, int idx)
        __releases(sp)
{
        rcu_lock_release(&(sp)->dep_map);
        __srcu_read_unlock(sp, idx);
}