From: Gleb Natapov <gleb@redhat.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>,
"avi.kivity@gmail.com" <avi.kivity@gmail.com>
Subject: Re: [PATCH 5/5] KVM: use eoi to track RTC interrupt delivery status
Date: Sun, 17 Mar 2013 16:00:20 +0200 [thread overview]
Message-ID: <20130317140020.GL11223@redhat.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E099E46A0@SHSMSX101.ccr.corp.intel.com>
On Sun, Mar 17, 2013 at 01:09:09PM +0000, Zhang, Yang Z wrote:
> >> @@ -241,6 +341,8 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int
> > irq)
> >> irqe.level = 1;
> >> irqe.shorthand = 0;
> >> + rtc_irq_update(ioapic, &irqe, irq);
> >> +
> > Do it once when GSI is configured.
> This function will set need_eoi to number of CPU received RTC interrupt. When GSI is configured, there is no real interrupt generated and if set need_eoi, no EOI will decrease it.
>
You made this function do two unrelated things: recalculate vcpu map and
track need_info. Former should be done during GSI configuration, later
here.
--
Gleb.
prev parent reply other threads:[~2013-03-17 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 8:04 [PATCH 0/5] use eoi to track RTC interrupt delivery status Yang Zhang
2013-03-15 8:04 ` [PATCH 1/5] KVM: parse ioapic entry to get destination vcpu Yang Zhang
2013-03-15 8:04 ` [PATCH 2/5] KVM: add vcpu info to ioapic_update_eoi() Yang Zhang
2013-03-15 8:04 ` [PATCH 3/5] KVM: introduce struct rtc_status Yang Zhang
2013-03-15 8:04 ` [PATCH 4/5] KVM: register rtc eoi notifier Yang Zhang
2013-03-17 10:19 ` Gleb Natapov
2013-03-15 8:05 ` [PATCH 5/5] KVM: use eoi to track RTC interrupt delivery status Yang Zhang
2013-03-17 10:28 ` Gleb Natapov
2013-03-17 13:09 ` Zhang, Yang Z
2013-03-17 14:00 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317140020.GL11223@redhat.com \
--to=gleb@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox