From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 5/5] KVM: use eoi to track RTC interrupt delivery status
Date: Sun, 17 Mar 2013 16:00:20 +0200
Message-ID: <20130317140020.GL11223@redhat.com>
References: <1363334700-24507-1-git-send-email-yang.z.zhang@intel.com>
 <1363334700-24507-6-git-send-email-yang.z.zhang@intel.com>
 <20130317102844.GH11223@redhat.com>
 <A9667DDFB95DB7438FA9D7D576C3D87E099E46A0@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	"Zhang, Xiantao" <xiantao.zhang@intel.com>,
	"avi.kivity@gmail.com" <avi.kivity@gmail.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:27186 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754583Ab3CQOAY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 17 Mar 2013 10:00:24 -0400
Content-Disposition: inline
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E099E46A0@SHSMSX101.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Mar 17, 2013 at 01:09:09PM +0000, Zhang, Yang Z wrote:
> >> @@ -241,6 +341,8 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int
> > irq)
> >>  	irqe.level = 1;
> >>  	irqe.shorthand = 0;
> >> +	rtc_irq_update(ioapic, &irqe, irq);
> >> +
> > Do it once when GSI is configured.
> This function will set need_eoi to number of CPU received RTC interrupt. When GSI is configured, there is no real interrupt generated and if set need_eoi, no EOI will decrease it. 
> 
You made this function do two unrelated things: recalculate vcpu map and
track need_info. Former should be done during GSI configuration, later
here.

--
			Gleb.