From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v2 4/8] KVM: Introduce struct rtc_status
Date: Mon, 18 Mar 2013 11:40:30 +0200
Message-ID: <20130318094030.GB4020@redhat.com>
References: <1363591479-4653-1-git-send-email-yang.z.zhang@intel.com>
 <1363591479-4653-5-git-send-email-yang.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, mtosatti@redhat.com, xiantao.zhang@intel.com
To: Yang Zhang <yang.z.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46952 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752251Ab3CRJkd (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 Mar 2013 05:40:33 -0400
Content-Disposition: inline
In-Reply-To: <1363591479-4653-5-git-send-email-yang.z.zhang@intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Mar 18, 2013 at 03:24:35PM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
> 
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> ---
>  virt/kvm/ioapic.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/virt/kvm/ioapic.h b/virt/kvm/ioapic.h
> index 2001b61..4904ca3 100644
> --- a/virt/kvm/ioapic.h
> +++ b/virt/kvm/ioapic.h
> @@ -34,6 +34,12 @@ struct kvm_vcpu;
>  #define	IOAPIC_INIT			0x5
>  #define	IOAPIC_EXTINT			0x7
>  
> +struct rtc_status {
> +	int need_eoi;
> +	DECLARE_BITMAP(vcpu_map, KVM_MAX_VCPUS);
> +	struct kvm_irq_ack_notifier irq_ack_notifier;
If we do not register ack notifier any more why do you need this here?
Also give the structure more kvmish name.

> +};
> +
>  struct kvm_ioapic {
>  	u64 base_address;
>  	u32 ioregsel;
> @@ -47,6 +53,9 @@ struct kvm_ioapic {
>  	void (*ack_notifier)(void *opaque, int irq);
>  	spinlock_t lock;
>  	DECLARE_BITMAP(handled_vectors, 256);
> +#ifdef CONFIG_X86
> +	struct rtc_status rtc_status;
> +#endif
>  };
>  
>  #ifdef DEBUG
> -- 
> 1.7.1

--
			Gleb.