From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH kvm-unit-tests 5/5] x86-run: Pull extra arguments from unittests.cfg Date: Wed, 20 Mar 2013 16:06:14 -0300 Message-ID: <20130320190614.GC3888@amt.cnet> References: <5281645450dd979bd892629ca148e594e90196d8.1363391818.git.crobinso@redhat.com> <6c4d82914d07c7d4203cd3bb0c0496f607758c31.1363391818.git.crobinso@redhat.com> <20130317152529.GP11223@redhat.com> <514658C0.4060605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gleb Natapov , kvm@vger.kernel.org To: Cole Robinson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755567Ab3CTTG2 (ORCPT ); Wed, 20 Mar 2013 15:06:28 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2KJ6SQ7017331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Mar 2013 15:06:28 -0400 Content-Disposition: inline In-Reply-To: <514658C0.4060605@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Mar 17, 2013 at 07:58:56PM -0400, Cole Robinson wrote: > On 03/17/2013 11:25 AM, Gleb Natapov wrote: > > On Fri, Mar 15, 2013 at 08:09:09PM -0400, Cole Robinson wrote: > >> Some tests want extra arguments as enumerated in unittests.cfg, > >> use them. > >> > >> unittests.cfg also has a few sections about invoking certains tests > >> with different combinations of options, but x86-run doesn't do > >> anything with that. > > With this it will not be possible to use x86-run outside of autotest, > > no? > > > > Not true, x86-run is still meant to be the standalone helper script for > running unittests. autotest doesn't care about x86-run, and ConfigParser is a > standard python module. > > x86/unittests.cfg already exists in the kvm-unit-tests repo, I assumed it was > encoding required test options but maybe I'm wrong about that. It's still > useful to build off of if there's value in running some tests with different > combinations of parameters. I fail to see what is the point here. unittests.cfg has been originally (and continues to be, AFAIK), intended for autotest: http://kerneltrap.org/mailarchive/linux-kvm/2010/6/24/6264146 Please don't remove manual execution from README.