From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] vfio-pci: integer overflow in vfio_pci_ioctl() Date: Tue, 26 Mar 2013 16:13:58 +0300 Message-ID: <20130326131358.GA11516@longonot.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiang Liu , Vijay Mohan Pandarathil , kvm@vger.kernel.org, kernel-janitors@vger.kernel.org To: Alex Williamson Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:35202 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933869Ab3CZNPu (ORCPT ); Tue, 26 Mar 2013 09:15:50 -0400 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: The worry here is that a large value of hdr.start would cause a read before the start of the array and a crash in vfio_msi_set_vector_signal(). The check in vfio_msi_set_block() is not enough: if (start + count > vdev->num_ctx) return -EINVAL; A large value of "start" would lead to an integer overflow. The check in vfio_msi_set_vector_signal() doesn't work either: if (vector >= vdev->num_ctx) return -EINVAL; Here "vector" is "count" casted to a signed int so it would be negative and thus smaller than "vdev->num_ctx" which is also a signed int. Signed-off-by: Dan Carpenter --- Static analysis stuff. Untested. This patch is not beautiful. There is probably a better limit to use if I knew the code. diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index acfcb1a..de54f69 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -371,6 +371,9 @@ static long vfio_pci_ioctl(void *device_data, hdr.count > vfio_pci_get_irq_count(vdev, hdr.index)) return -EINVAL; + if (hdr.start > INT_MAX - hdr.count) + return -EINVAL; + data = memdup_user((void __user *)(arg + minsz), hdr.count * size); if (IS_ERR(data))