From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs Date: Sun, 31 Mar 2013 10:46:00 +0300 Message-ID: <20130331074559.GD23484@redhat.com> References: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: target-devel , lf-virt , kvm-devel , qemu-devel , Stefan Hajnoczi , Paolo Bonzini , Asias He , Anthony Liguori To: "Nicholas A. Bellinger" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62627 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756368Ab3CaHpT (ORCPT ); Sun, 31 Mar 2013 03:45:19 -0400 Content-Disposition: inline In-Reply-To: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Mar 29, 2013 at 04:33:09AM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > This series adds a virtio_queue_valid() for use by virtio-pci code in > order to prevent opreations upon uninitialized VQs, that is currently > expected to occur during seabios setup of virtio-scsi. > > This also includes a vhost specific check for uninitialized VQs in > vhost_verify_ring_mappings() to avoid this same case. > > Please review. > > --nab Okay, and does this fix the failures in vhost_verify_ring_mappings that you've observed? > Michael S. Tsirkin (1): > virtio: add API to check that ring is setup > > Nicholas Bellinger (2): > virtio-pci: Add virtio_queue_valid checks ahead of > virtio_queue_get_num > vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings > > hw/vhost.c | 3 +++ > hw/virtio-pci.c | 27 +++++++++++++++++++++++++++ > hw/virtio.c | 5 +++++ > hw/virtio.h | 1 + > 4 files changed, 36 insertions(+), 0 deletions(-) > > -- > 1.7.2.5