Re: [PATCH 4/4] pci: add pci test device

Michael S. Tsirkin
2013-04-03T10:37:53Z

On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote:
> Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto:
> > > Because someone wasn't looking. :) The hw/ reorganization patches I've
> > > posted fix that.
> >
> > Still not sure how to merge this, if it goes in through my tree
> > and that's the only comment, I'll just fix it silently ...
>
> Indeed. In fact, considering my hw/ reorganization patches will be
> committed soon, please put it in hw/pci (matching hw/isa/pc-testdev.c).

Paolo, hw/pci is pci core, I haven't looked at your reorg patches,
but please do not move devices there.
Sorting devices by connection is also wrong I think, by function
would be better.

> Another comment is that you should add a description in docs/specs.
>
> Paolo

pc-test has none ... I'll see what I can do.

--
MST