Re: [PATCH 4/4] pci: add pci test device

Michael S. Tsirkin
2013-04-03T14:27:11Z

On Wed, Apr 03, 2013 at 04:08:45PM +0200, Paolo Bonzini wrote:
> Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto:
> > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI
> > > devices.
> >
> > That's too much nesting I think. hw/bridge/ and we can put isa bridges there
> > as well then.
>
> You need to group similar devices for the nesting to be useful. For
> example, it should be easy to check if something is true of all ISA
> bridges, or to do the same change in all of them. ISA and PCI bridges
> have too little in common for that (and why not put I2C and SPI in
> hw/bridge too :)).
>
> Paolo

Yes, why not. What all bridges need to share is their modeling
needs to be similar. That's one thing that practically
needs to be cleaned up I think.

--
MST