From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 4/4] pci: add pci test device Date: Wed, 3 Apr 2013 17:28:04 +0300 Message-ID: <20130403142804.GA23848@redhat.com> References: <20130403102229.GD18179@redhat.com> <515C037E.5030706@redhat.com> <20130403103301.GG18179@redhat.com> <515C05B0.2000401@redhat.com> <20130403103846.GB18725@redhat.com> <515C1719.903@redhat.com> <20130403120041.GA22200@redhat.com> <515C1B0C.3070505@redhat.com> <20130403140648.GC22200@redhat.com> <515C37ED.1070104@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4570 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755529Ab3DCO1L (ORCPT ); Wed, 3 Apr 2013 10:27:11 -0400 Content-Disposition: inline In-Reply-To: <515C37ED.1070104@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 03, 2013 at 04:08:45PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > > devices. > > > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > > as well then. > > You need to group similar devices for the nesting to be useful. For > example, it should be easy to check if something is true of all ISA > bridges, or to do the same change in all of them. ISA and PCI bridges > have too little in common for that (and why not put I2C and SPI in > hw/bridge too :)). > > Paolo Yes, why not. What all bridges need to share is their modeling needs to be similar. That's one thing that practically needs to be cleaned up I think. -- MST