From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] x86: kvmclock: Do not setup kvmclock vsyscall in the absence of that clock Date: Sun, 7 Apr 2013 14:45:49 +0300 Message-ID: <20130407114548.GR17919@redhat.com> References: <5128E8C9.1050000@web.de> <20130227111955.GC23616@redhat.com> <51615971.9050604@web.de> <20130407113709.GQ17919@redhat.com> <51615AC8.8030308@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42987 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933467Ab3DGLpu (ORCPT ); Sun, 7 Apr 2013 07:45:50 -0400 Content-Disposition: inline In-Reply-To: <51615AC8.8030308@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Apr 07, 2013 at 01:38:48PM +0200, Jan Kiszka wrote: > On 2013-04-07 13:37, Gleb Natapov wrote: > > On Sun, Apr 07, 2013 at 01:33:05PM +0200, Jan Kiszka wrote: > >> On 2013-02-27 12:19, Gleb Natapov wrote: > >>> On Sat, Feb 23, 2013 at 05:05:29PM +0100, Jan Kiszka wrote: > >>>> From: Jan Kiszka > >>>> > >>>> This fixes boot lockups with "no-kvmclock", when the host is not > >>>> exposing this particular feature (QEMU: -cpu ...,-kvmclock) or when > >>>> the kvmclock initialization failed for whatever reason. > >>>> > >>>> Signed-off-by: Jan Kiszka > >>> Applied, thanks. > >> > >> Just noticed that this fix isn't in Linus tree yet, thus also not yet in > >> 3.8.y. Which route does it take? > >> > > It is scheduled to go into 3.10. To get it into 3.8.y we need to send it > > to stable@. > > Hmm, it's a bug fix for an ugly early kernel crash... > It was not a regression introduced in 3.9 and this usually means that fix is delayed to the next merge window. Severe bugs with simple fix could be exceptions, and I probably misjudged this one. Note that the patch is for 3.9 would have helped to avoid that. As it stands the patch will go to 3.9 via stable. -- Gleb.