From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC PATCH v3 1/6] kvm: add device control API
Date: Mon, 8 Apr 2013 15:33:13 +1000
Message-ID: <20130408053313.GA8932@iris.ozlabs.ibm.com>
References: <1364856473-25245-1-git-send-email-scottwood@freescale.com>
 <1364954273-18196-1-git-send-email-scottwood@freescale.com>
 <1364954273-18196-2-git-send-email-scottwood@freescale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexander Graf <agraf@suse.de>, kvm-ppc@vger.kernel.org,
	kvm@vger.kernel.org
To: Scott Wood <scottwood@freescale.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:41605 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932537Ab3DHFd2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 8 Apr 2013 01:33:28 -0400
Content-Disposition: inline
In-Reply-To: <1364954273-18196-2-git-send-email-scottwood@freescale.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Apr 02, 2013 at 08:57:48PM -0500, Scott Wood wrote:

[snip]

> +static int kvm_ioctl_create_device(struct kvm *kvm,
> +				   struct kvm_create_device *cd)
> +{
> +	bool test = cd->flags & KVM_CREATE_DEVICE_TEST;
> +
> +	switch (cd->type) {
> +	default:
> +		return -ENODEV;
> +	}
> +}

This gives a compile error saying "error: unused variable `test'",
which is fatal since this gets compiled under arch/powerpc/kvm, and we
treat all warnings as errors there.

This still gives a compile error at the end of your series if you try
to compile with CONFIG_KVM_MPIC=n.

Paul.