From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoffer Dall <cdall@cs.columbia.edu>
Cc: Alexander Graf <agraf@suse.de>,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
Yang Zhang <yang.z.zhang@intel.com>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] KVM: ARM: Fix kvm_vm_ioctl_irq_line
Date: Tue, 16 Apr 2013 18:16:24 -0300 [thread overview]
Message-ID: <20130416211624.GA21244@amt.cnet> (raw)
In-Reply-To: <CAEDV+gJTMMthyazN=hLJu0sYTgvFY9MdzDMdS7J1w=bgWb8D3Q@mail.gmail.com>
On Tue, Apr 16, 2013 at 11:07:40AM -0700, Christoffer Dall wrote:
> On Tue, Apr 16, 2013 at 10:21 AM, Alexander Graf <agraf@suse.de> wrote:
> > Commit aa2fbe6d broke the ARM KVM target by introducing a new parameter
> > to irq handling functions.
> >
> > Fix the function prototype to get things compiling again and ignore the
> > parameter just like we did before
> >
> > Signed-off-by: Alexander Graf <agraf@suse.de>
> > ---
> > arch/arm/kvm/arm.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> > index e4ad0bb..678596f 100644
> > --- a/arch/arm/kvm/arm.c
> > +++ b/arch/arm/kvm/arm.c
> > @@ -805,7 +805,8 @@ static int vcpu_interrupt_line(struct kvm_vcpu *vcpu, int number, bool level)
> > return 0;
> > }
> >
> > -int kvm_vm_ioctl_irq_line(struct kvm *kvm, struct kvm_irq_level *irq_level)
> > +int kvm_vm_ioctl_irq_line(struct kvm *kvm, struct kvm_irq_level *irq_level,
> > + bool line_status)
> > {
> > u32 irq = irq_level->irq;
> > unsigned int irq_type, vcpu_idx, irq_num;
> > --
> > 1.6.0.2
> >
>
> Acked-by: Christoffer Dall <cdall@cs.columbia.edu>
Applied, thanks.
prev parent reply other threads:[~2013-04-16 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 17:21 [PATCH] KVM: ARM: Fix kvm_vm_ioctl_irq_line Alexander Graf
2013-04-16 18:07 ` Christoffer Dall
2013-04-16 21:16 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416211624.GA21244@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=cdall@cs.columbia.edu \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox