[GIT PULL v2] KVM/ARM Minor fixes for 3.9

[GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Christoffer Dall]

The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6:

  Linux 3.9-rc6 (2013-04-07 20:49:54 -0700)

are available in the git repository at:

  git://github.com/columbia/linux-kvm-arm.git kvm-arm-fixes-3.9

for you to fetch changes up to 865499ea90d399e0682bcce3ae7af24277633699:

  ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write (2013-04-16
16:21:25 -0700)

----------------------------------------------------------------
Marc Zyngier (2):
      ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
      ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write

 arch/arm/include/asm/pgtable-3level.h |    2 +-
 arch/arm/kvm/arm.c                    |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Marc Zyngier]

On Tue, 16 Apr 2013 16:25:10 -0700, Christoffer Dall
<cdall@cs.columbia.edu> wrote:
> The following changes since commit
> 31880c37c11e28cb81c70757e38392b42e695dc6:
> 
>   Linux 3.9-rc6 (2013-04-07 20:49:54 -0700)
> 
> are available in the git repository at:
> 
>   git://github.com/columbia/linux-kvm-arm.git kvm-arm-fixes-3.9
> 
> for you to fetch changes up to 865499ea90d399e0682bcce3ae7af24277633699:
> 
>   ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write (2013-04-16
> 16:21:25 -0700)
> 
> ----------------------------------------------------------------
> Marc Zyngier (2):
>       ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
>       ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write
> 
>  arch/arm/include/asm/pgtable-3level.h |    2 +-
>  arch/arm/kvm/arm.c                    |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

How about also adding:
"ARM: KVM: fix unbalanced get_cpu() in access_dcsw" (commit 685bee3 in my
kvm-arm/pre-arm64 branch)?
It could easily be triggered by a malicious guest...

Thanks,

        M.
-- 
Fast, cheap, reliable. Pick two.

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Gleb Natapov]

On Wed, Apr 17, 2013 at 02:10:01AM -0700, Christoffer Dall wrote:
> On Wed, Apr 17, 2013 at 1:05 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> 
> > On Tue, 16 Apr 2013 16:25:10 -0700, Christoffer Dall
> > <cdall@cs.columbia.edu> wrote:
> > > The following changes since commit
> > > 31880c37c11e28cb81c70757e38392b42e695dc6:
> > >
> > >   Linux 3.9-rc6 (2013-04-07 20:49:54 -0700)
> > >
> > > are available in the git repository at:
> > >
> > >   git://github.com/columbia/linux-kvm-arm.git kvm-arm-fixes-3.9
> > >
> > > for you to fetch changes up to 865499ea90d399e0682bcce3ae7af24277633699:
> > >
> > >   ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write (2013-04-16
> > > 16:21:25 -0700)
> > >
> > > ----------------------------------------------------------------
> > > Marc Zyngier (2):
> > >       ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
> > >       ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write
> > >
> > >  arch/arm/include/asm/pgtable-3level.h |    2 +-
> > >  arch/arm/kvm/arm.c                    |    1 +
> > >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > How about also adding:
> > "ARM: KVM: fix unbalanced get_cpu() in access_dcsw" (commit 685bee3 in my
> > kvm-arm/pre-arm64 branch)?
> >
> >
> sure, I updated the branch:
> 
> The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6:
> 
>   Linux 3.9-rc6 (2013-04-07 20:49:54 -0700)
> 
> are available in the git repository at:
> 
>   git://github.com/columbia/linux-kvm-arm.git kvm-arm-fixes-3.9
> 
> for you to fetch changes up to 31714c19553835558919a85f038bbe4b03b11078:
> 
>   ARM: KVM: fix unbalanced get_cpu() in access_dcsw (2013-04-17 02:08:04
> -0700)
> 
> ----------------------------------------------------------------
> Marc Zyngier (3):
>       ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
>       ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write
Those two are in upstream already. Guys you shouldn't wait with the
important bugfixes until -rc7. 3.9 can be released any moment now.

>       ARM: KVM: fix unbalanced get_cpu() in access_dcsw

> 
>  arch/arm/include/asm/pgtable-3level.h |    2 +-
>  arch/arm/kvm/arm.c                    |    1 +
>  arch/arm/kvm/coproc.c                 |    4 ++--
>  3 files changed, 4 insertions(+), 3 deletions(-)

--
			Gleb.

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Gleb Natapov]

On Wed, Apr 17, 2013 at 12:28:15PM +0200, Alexander Graf wrote:
> 
> On 17.04.2013, at 12:17, Christoffer Dall wrote:
> 
> > 
> > 
> > 
> > On Wed, Apr 17, 2013 at 2:20 AM, Gleb Natapov <gleb@redhat.com> wrote:
> > On Wed, Apr 17, 2013 at 02:10:01AM -0700, Christoffer Dall wrote:
> > > On Wed, Apr 17, 2013 at 1:05 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> > >
> > > > On Tue, 16 Apr 2013 16:25:10 -0700, Christoffer Dall
> > > > <cdall@cs.columbia.edu> wrote:
> > > > > The following changes since commit
> > > > > 31880c37c11e28cb81c70757e38392b42e695dc6:
> > > > >
> > > > >   Linux 3.9-rc6 (2013-04-07 20:49:54 -0700)
> > > > >
> > > > > are available in the git repository at:
> > > > >
> > > > >   git://github.com/columbia/linux-kvm-arm.git kvm-arm-fixes-3.9
> > > > >
> > > > > for you to fetch changes up to 865499ea90d399e0682bcce3ae7af24277633699:
> > > > >
> > > > >   ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write (2013-04-16
> > > > > 16:21:25 -0700)
> > > > >
> > > > > ----------------------------------------------------------------
> > > > > Marc Zyngier (2):
> > > > >       ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
> > > > >       ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write
> > > > >
> > > > >  arch/arm/include/asm/pgtable-3level.h |    2 +-
> > > > >  arch/arm/kvm/arm.c                    |    1 +
> > > > >  2 files changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > How about also adding:
> > > > "ARM: KVM: fix unbalanced get_cpu() in access_dcsw" (commit 685bee3 in my
> > > > kvm-arm/pre-arm64 branch)?
> > > >
> > > >
> > > sure, I updated the branch:
> > >
> > > The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6:
> > >
> > >   Linux 3.9-rc6 (2013-04-07 20:49:54 -0700)
> > >
> > > are available in the git repository at:
> > >
> > >   git://github.com/columbia/linux-kvm-arm.git kvm-arm-fixes-3.9
> > >
> > > for you to fetch changes up to 31714c19553835558919a85f038bbe4b03b11078:
> > >
> > >   ARM: KVM: fix unbalanced get_cpu() in access_dcsw (2013-04-17 02:08:04
> > > -0700)
> > >
> > > ----------------------------------------------------------------
> > > Marc Zyngier (3):
> > >       ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
> > >       ARM: KVM: fix L_PTE_S2_RDWR to actually be Read/Write
> > Those two are in upstream already. Guys you shouldn't wait with the
> > important bugfixes until -rc7. 3.9 can be released any moment now.
> > 
> > 
> > Right, so that's the same commits so you could just fast-forward kvm/master by pulling from the same branch.
> > 
> > I thought you were going to send this to Linus before the 3.9 release, which is what I asked you and Marcelo a couple of days back.
> > 
> > So now I'm confused again: are you telling me to send a pull-request directly to Linus for these three patches?
> 
> No, he's telling you that Marcelo already sent a pull request to Linus last night, so the 3rd patch came too late.
> 
Yes. Marcelo has sent pull request yesterday and Linus pulled it
already. Sorry if I was not clear. Generally specking we should not wait
so late into the release to send fixes to Linus, exceptions happen of
course.

--
			Gleb.

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Christoffer Dall]

On Wed, Apr 17, 2013 at 3:45 AM, Gleb Natapov <gleb@redhat.com> wrote:
> Marcelo has sent pull request yesterday and Linus pulled it
> already. Sorry if I was not clear. Generally specking we should not wait
> so late into the release to send fixes to Linus, exceptions happen of
> course.

I know, the reason everything got held up so late was that I had a
longer series of fixes that I prepared early, which the ARM guys
thought should be held back until -rc5, and in the end RMK merged this
series.  Only quite recently did I find out that these were then not
intended to be merged for 3.9, but rather for next.

Any reason why we can't merge the last one-line patch now and send
another pull request to Linus at this point - with my apologies?

-Christoffer

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Alexander Graf]

On 17.04.2013, at 13:05, Christoffer Dall wrote:

> On Wed, Apr 17, 2013 at 3:45 AM, Gleb Natapov <gleb@redhat.com> wrote:
>> Marcelo has sent pull request yesterday and Linus pulled it
>> already. Sorry if I was not clear. Generally specking we should not wait
>> so late into the release to send fixes to Linus, exceptions happen of
>> course.
> 
> I know, the reason everything got held up so late was that I had a
> longer series of fixes that I prepared early, which the ARM guys
> thought should be held back until -rc5, and in the end RMK merged this
> series.  Only quite recently did I find out that these were then not
> intended to be merged for 3.9, but rather for next.
> 
> Any reason why we can't merge the last one-line patch now and send
> another pull request to Linus at this point - with my apologies?

Would it hurt badly if that one-liner goes into 3.9 through stable? If it makes it to 3.10-rc1, it should be basically in 3.9.1 already.


Alex

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Christoffer Dall]

On Wed, Apr 17, 2013 at 4:08 AM, Alexander Graf <agraf@suse.de> wrote:
>
> On 17.04.2013, at 13:05, Christoffer Dall wrote:
>
>> On Wed, Apr 17, 2013 at 3:45 AM, Gleb Natapov <gleb@redhat.com> wrote:
>>> Marcelo has sent pull request yesterday and Linus pulled it
>>> already. Sorry if I was not clear. Generally specking we should not wait
>>> so late into the release to send fixes to Linus, exceptions happen of
>>> course.
>>
>> I know, the reason everything got held up so late was that I had a
>> longer series of fixes that I prepared early, which the ARM guys
>> thought should be held back until -rc5, and in the end RMK merged this
>> series.  Only quite recently did I find out that these were then not
>> intended to be merged for 3.9, but rather for next.
>>
>> Any reason why we can't merge the last one-line patch now and send
>> another pull request to Linus at this point - with my apologies?
>
> Would it hurt badly if that one-liner goes into 3.9 through stable? If it makes it to 3.10-rc1, it should be basically in 3.9.1 already.
>
Since it's a very easy way for a guest to disable preemption on the
host, it's a pretty bad bug, that should be fixed, and it would really
be great if it could be fixed in 3.9, so I would strongly prefer that.
 Why is it a big deal?

Re: [GIT PULL v2] KVM/ARM Minor fixes for 3.9

[Gleb Natapov]

On Wed, Apr 17, 2013 at 04:05:31AM -0700, Christoffer Dall wrote:
> On Wed, Apr 17, 2013 at 3:45 AM, Gleb Natapov <gleb@redhat.com> wrote:
> > Marcelo has sent pull request yesterday and Linus pulled it
> > already. Sorry if I was not clear. Generally specking we should not wait
> > so late into the release to send fixes to Linus, exceptions happen of
> > course.
> 
> I know, the reason everything got held up so late was that I had a
> longer series of fixes that I prepared early, which the ARM guys
> thought should be held back until -rc5, and in the end RMK merged this
> series.  Only quite recently did I find out that these were then not
> intended to be merged for 3.9, but rather for next.
> 
> Any reason why we can't merge the last one-line patch now and send
> another pull request to Linus at this point - with my apologies?
> 
Marcelo is in charge of kvm.git this week. If Linus will not release 3.9
till Marcelo start to work it may be still possible, but you need to
prepare new pull request against master and for that Marcelo needs to
pull master back from upstream.

--
			Gleb.