* [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*() [not found] <1366073209-27119-1-git-send-email-afaerber@suse.de> @ 2013-04-16 0:46 ` Andreas Färber 2013-04-18 9:18 ` Gleb Natapov 0 siblings, 1 reply; 2+ messages in thread From: Andreas Färber @ 2013-04-16 0:46 UTC (permalink / raw) To: qemu-devel Cc: Igor Mammedov, Andreas Färber, Gleb Natapov, Marcelo Tosatti, open list:Overall From: Igor Mammedov <imammedo@redhat.com> ... so it could be called without requiring CPUArchState. Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Andreas Färber <afaerber@suse.de> --- cpus.c | 4 ++-- include/sysemu/kvm.h | 12 ++++++------ kvm-all.c | 8 ++------ kvm-stub.c | 4 ++-- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/cpus.c b/cpus.c index 97e9ab4..c15ff6c 100644 --- a/cpus.c +++ b/cpus.c @@ -419,7 +419,7 @@ void cpu_synchronize_all_post_reset(void) CPUArchState *cpu; for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) { - cpu_synchronize_post_reset(cpu); + cpu_synchronize_post_reset(ENV_GET_CPU(cpu)); } } @@ -428,7 +428,7 @@ void cpu_synchronize_all_post_init(void) CPUArchState *cpu; for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) { - cpu_synchronize_post_init(cpu); + cpu_synchronize_post_init(ENV_GET_CPU(cpu)); } } diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index f2d97b5..495e6f8 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu/kvm.h @@ -250,8 +250,8 @@ int kvm_check_extension(KVMState *s, unsigned int extension); uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, uint32_t index, int reg); void kvm_cpu_synchronize_state(CPUArchState *env); -void kvm_cpu_synchronize_post_reset(CPUArchState *env); -void kvm_cpu_synchronize_post_init(CPUArchState *env); +void kvm_cpu_synchronize_post_reset(CPUState *cpu); +void kvm_cpu_synchronize_post_init(CPUState *cpu); /* generic hooks - to be moved/refactored once there are more users */ @@ -262,17 +262,17 @@ static inline void cpu_synchronize_state(CPUArchState *env) } } -static inline void cpu_synchronize_post_reset(CPUArchState *env) +static inline void cpu_synchronize_post_reset(CPUState *cpu) { if (kvm_enabled()) { - kvm_cpu_synchronize_post_reset(env); + kvm_cpu_synchronize_post_reset(cpu); } } -static inline void cpu_synchronize_post_init(CPUArchState *env) +static inline void cpu_synchronize_post_init(CPUState *cpu) { if (kvm_enabled()) { - kvm_cpu_synchronize_post_init(env); + kvm_cpu_synchronize_post_init(cpu); } } diff --git a/kvm-all.c b/kvm-all.c index 9b433d3..fc4e17c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1510,18 +1510,14 @@ void kvm_cpu_synchronize_state(CPUArchState *env) } } -void kvm_cpu_synchronize_post_reset(CPUArchState *env) +void kvm_cpu_synchronize_post_reset(CPUState *cpu) { - CPUState *cpu = ENV_GET_CPU(env); - kvm_arch_put_registers(cpu, KVM_PUT_RESET_STATE); cpu->kvm_vcpu_dirty = false; } -void kvm_cpu_synchronize_post_init(CPUArchState *env) +void kvm_cpu_synchronize_post_init(CPUState *cpu) { - CPUState *cpu = ENV_GET_CPU(env); - kvm_arch_put_registers(cpu, KVM_PUT_FULL_STATE); cpu->kvm_vcpu_dirty = false; } diff --git a/kvm-stub.c b/kvm-stub.c index f6137d3..723a813 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -41,11 +41,11 @@ void kvm_cpu_synchronize_state(CPUArchState *env) { } -void kvm_cpu_synchronize_post_reset(CPUArchState *env) +void kvm_cpu_synchronize_post_reset(CPUState *cpu) { } -void kvm_cpu_synchronize_post_init(CPUArchState *env) +void kvm_cpu_synchronize_post_init(CPUState *cpu) { } -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*() 2013-04-16 0:46 ` [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*() Andreas Färber @ 2013-04-18 9:18 ` Gleb Natapov 0 siblings, 0 replies; 2+ messages in thread From: Gleb Natapov @ 2013-04-18 9:18 UTC (permalink / raw) To: Andreas Färber Cc: Igor Mammedov, Marcelo Tosatti, qemu-devel, open list:Overall On Tue, Apr 16, 2013 at 02:46:47AM +0200, Andreas Färber wrote: > From: Igor Mammedov <imammedo@redhat.com> > > ... so it could be called without requiring CPUArchState. > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> Acked-by: Gleb Natapov <gleb@redhat.com> > --- > cpus.c | 4 ++-- > include/sysemu/kvm.h | 12 ++++++------ > kvm-all.c | 8 ++------ > kvm-stub.c | 4 ++-- > 4 files changed, 12 insertions(+), 16 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 97e9ab4..c15ff6c 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -419,7 +419,7 @@ void cpu_synchronize_all_post_reset(void) > CPUArchState *cpu; > > for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) { > - cpu_synchronize_post_reset(cpu); > + cpu_synchronize_post_reset(ENV_GET_CPU(cpu)); > } > } > > @@ -428,7 +428,7 @@ void cpu_synchronize_all_post_init(void) > CPUArchState *cpu; > > for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) { > - cpu_synchronize_post_init(cpu); > + cpu_synchronize_post_init(ENV_GET_CPU(cpu)); > } > } > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index f2d97b5..495e6f8 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -250,8 +250,8 @@ int kvm_check_extension(KVMState *s, unsigned int extension); > uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, > uint32_t index, int reg); > void kvm_cpu_synchronize_state(CPUArchState *env); > -void kvm_cpu_synchronize_post_reset(CPUArchState *env); > -void kvm_cpu_synchronize_post_init(CPUArchState *env); > +void kvm_cpu_synchronize_post_reset(CPUState *cpu); > +void kvm_cpu_synchronize_post_init(CPUState *cpu); > > /* generic hooks - to be moved/refactored once there are more users */ > > @@ -262,17 +262,17 @@ static inline void cpu_synchronize_state(CPUArchState *env) > } > } > > -static inline void cpu_synchronize_post_reset(CPUArchState *env) > +static inline void cpu_synchronize_post_reset(CPUState *cpu) > { > if (kvm_enabled()) { > - kvm_cpu_synchronize_post_reset(env); > + kvm_cpu_synchronize_post_reset(cpu); > } > } > > -static inline void cpu_synchronize_post_init(CPUArchState *env) > +static inline void cpu_synchronize_post_init(CPUState *cpu) > { > if (kvm_enabled()) { > - kvm_cpu_synchronize_post_init(env); > + kvm_cpu_synchronize_post_init(cpu); > } > } > > diff --git a/kvm-all.c b/kvm-all.c > index 9b433d3..fc4e17c 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1510,18 +1510,14 @@ void kvm_cpu_synchronize_state(CPUArchState *env) > } > } > > -void kvm_cpu_synchronize_post_reset(CPUArchState *env) > +void kvm_cpu_synchronize_post_reset(CPUState *cpu) > { > - CPUState *cpu = ENV_GET_CPU(env); > - > kvm_arch_put_registers(cpu, KVM_PUT_RESET_STATE); > cpu->kvm_vcpu_dirty = false; > } > > -void kvm_cpu_synchronize_post_init(CPUArchState *env) > +void kvm_cpu_synchronize_post_init(CPUState *cpu) > { > - CPUState *cpu = ENV_GET_CPU(env); > - > kvm_arch_put_registers(cpu, KVM_PUT_FULL_STATE); > cpu->kvm_vcpu_dirty = false; > } > diff --git a/kvm-stub.c b/kvm-stub.c > index f6137d3..723a813 100644 > --- a/kvm-stub.c > +++ b/kvm-stub.c > @@ -41,11 +41,11 @@ void kvm_cpu_synchronize_state(CPUArchState *env) > { > } > > -void kvm_cpu_synchronize_post_reset(CPUArchState *env) > +void kvm_cpu_synchronize_post_reset(CPUState *cpu) > { > } > > -void kvm_cpu_synchronize_post_init(CPUArchState *env) > +void kvm_cpu_synchronize_post_init(CPUState *cpu) > { > } > > -- > 1.8.1.4 -- Gleb. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-18 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1366073209-27119-1-git-send-email-afaerber@suse.de>
2013-04-16 0:46 ` [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*() Andreas Färber
2013-04-18 9:18 ` Gleb Natapov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox