* [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
@ 2013-04-27 3:42 Asias He
2013-04-28 12:43 ` Michael S. Tsirkin
2013-05-01 6:42 ` Michael S. Tsirkin
0 siblings, 2 replies; 6+ messages in thread
From: Asias He @ 2013-04-27 3:42 UTC (permalink / raw)
To: Nicholas Bellinger
Cc: kvm, Michael S. Tsirkin, virtualization, target-devel,
Stefan Hajnoczi, Paolo Bonzini
Signed-off-by: Asias He <asias@redhat.com>
---
drivers/vhost/tcm_vhost.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
index 1677238..bddc39a 100644
--- a/drivers/vhost/tcm_vhost.c
+++ b/drivers/vhost/tcm_vhost.c
@@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("vhost_scsi");
module_init(tcm_vhost_init);
module_exit(tcm_vhost_exit);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
2013-04-27 3:42 [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost Asias He
@ 2013-04-28 12:43 ` Michael S. Tsirkin
2013-05-01 6:42 ` Michael S. Tsirkin
1 sibling, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2013-04-28 12:43 UTC (permalink / raw)
To: Asias He
Cc: kvm, virtualization, target-devel, Stefan Hajnoczi, Paolo Bonzini
On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:
> Signed-off-by: Asias He <asias@redhat.com>
Makes sense.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
In fact, how about we turn this around, and
rename tcm_vhost.c to scsi.c and module to vhost_scsi,
make tcm_vhost an alias?
> ---
> drivers/vhost/tcm_vhost.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> index 1677238..bddc39a 100644
> --- a/drivers/vhost/tcm_vhost.c
> +++ b/drivers/vhost/tcm_vhost.c
> @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
>
> MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("vhost_scsi");
> module_init(tcm_vhost_init);
> module_exit(tcm_vhost_exit);
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
2013-04-27 3:42 [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost Asias He
2013-04-28 12:43 ` Michael S. Tsirkin
@ 2013-05-01 6:42 ` Michael S. Tsirkin
2013-05-01 16:07 ` Nicholas A. Bellinger
2013-05-02 4:27 ` Asias He
1 sibling, 2 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2013-05-01 6:42 UTC (permalink / raw)
To: Asias He
Cc: kvm, virtualization, target-devel, Stefan Hajnoczi, Paolo Bonzini
On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:
> Signed-off-by: Asias He <asias@redhat.com>
Nicholas, thoughts?
How about we move tcm_vhost.c to scsi.c
call module vhost_scsi and add tcm_vhost as an alias?
If not - want this alias in?
> ---
> drivers/vhost/tcm_vhost.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> index 1677238..bddc39a 100644
> --- a/drivers/vhost/tcm_vhost.c
> +++ b/drivers/vhost/tcm_vhost.c
> @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
>
> MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("vhost_scsi");
> module_init(tcm_vhost_init);
> module_exit(tcm_vhost_exit);
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
2013-05-01 6:42 ` Michael S. Tsirkin
@ 2013-05-01 16:07 ` Nicholas A. Bellinger
2013-05-01 17:02 ` Michael S. Tsirkin
2013-05-02 4:27 ` Asias He
1 sibling, 1 reply; 6+ messages in thread
From: Nicholas A. Bellinger @ 2013-05-01 16:07 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Asias He, Paolo Bonzini, Stefan Hajnoczi, Rusty Russell, kvm,
virtualization, target-devel
On Wed, 2013-05-01 at 09:42 +0300, Michael S. Tsirkin wrote:
> On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:
> > Signed-off-by: Asias He <asias@redhat.com>
>
>
> Nicholas, thoughts?
> How about we move tcm_vhost.c to scsi.c
> call module vhost_scsi and add tcm_vhost as an alias?
> If not - want this alias in?
>
No objection on my side..
Shall I rebase a branch on top of your vhost-net-next + perform the
rename, or do you want to send this via net-next..?
--nab
> > ---
> > drivers/vhost/tcm_vhost.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> > index 1677238..bddc39a 100644
> > --- a/drivers/vhost/tcm_vhost.c
> > +++ b/drivers/vhost/tcm_vhost.c
> > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
> >
> > MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
> > MODULE_LICENSE("GPL");
> > +MODULE_ALIAS("vhost_scsi");
> > module_init(tcm_vhost_init);
> > module_exit(tcm_vhost_exit);
> > --
> > 1.8.1.4
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
2013-05-01 16:07 ` Nicholas A. Bellinger
@ 2013-05-01 17:02 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2013-05-01 17:02 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: kvm, virtualization, target-devel, Stefan Hajnoczi, Paolo Bonzini
On Wed, May 01, 2013 at 09:07:56AM -0700, Nicholas A. Bellinger wrote:
> On Wed, 2013-05-01 at 09:42 +0300, Michael S. Tsirkin wrote:
> > On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:
> > > Signed-off-by: Asias He <asias@redhat.com>
> >
> >
> > Nicholas, thoughts?
> > How about we move tcm_vhost.c to scsi.c
> > call module vhost_scsi and add tcm_vhost as an alias?
> > If not - want this alias in?
> >
>
> No objection on my side..
>
> Shall I rebase a branch on top of your vhost-net-next + perform the
> rename, or do you want to send this via net-next..?
>
> --nab
Probably easier if I'll do it, but this should go direct
to Linus, not through net.
> > > ---
> > > drivers/vhost/tcm_vhost.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> > > index 1677238..bddc39a 100644
> > > --- a/drivers/vhost/tcm_vhost.c
> > > +++ b/drivers/vhost/tcm_vhost.c
> > > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
> > >
> > > MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
> > > MODULE_LICENSE("GPL");
> > > +MODULE_ALIAS("vhost_scsi");
> > > module_init(tcm_vhost_init);
> > > module_exit(tcm_vhost_exit);
> > > --
> > > 1.8.1.4
> > --
> > To unsubscribe from this list: send the line "unsubscribe target-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
2013-05-01 6:42 ` Michael S. Tsirkin
2013-05-01 16:07 ` Nicholas A. Bellinger
@ 2013-05-02 4:27 ` Asias He
1 sibling, 0 replies; 6+ messages in thread
From: Asias He @ 2013-05-02 4:27 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, virtualization, target-devel, Stefan Hajnoczi, Paolo Bonzini
On Wed, May 01, 2013 at 09:42:22AM +0300, Michael S. Tsirkin wrote:
> On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:
> > Signed-off-by: Asias He <asias@redhat.com>
>
>
> Nicholas, thoughts?
> How about we move tcm_vhost.c to scsi.c
> call module vhost_scsi and add tcm_vhost as an alias?
This is even better ;-)
> If not - want this alias in?
>
> > ---
> > drivers/vhost/tcm_vhost.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> > index 1677238..bddc39a 100644
> > --- a/drivers/vhost/tcm_vhost.c
> > +++ b/drivers/vhost/tcm_vhost.c
> > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
> >
> > MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
> > MODULE_LICENSE("GPL");
> > +MODULE_ALIAS("vhost_scsi");
> > module_init(tcm_vhost_init);
> > module_exit(tcm_vhost_exit);
> > --
> > 1.8.1.4
--
Asias
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-02 4:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-27 3:42 [PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost Asias He
2013-04-28 12:43 ` Michael S. Tsirkin
2013-05-01 6:42 ` Michael S. Tsirkin
2013-05-01 16:07 ` Nicholas A. Bellinger
2013-05-01 17:02 ` Michael S. Tsirkin
2013-05-02 4:27 ` Asias He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox