From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v3 07/32] arm64: KVM: fault injection into a guest Date: Mon, 29 Apr 2013 17:26:52 +0100 Message-ID: <20130429162652.GA16544@arm.com> References: <1365437854-30214-1-git-send-email-marc.zyngier@arm.com> <1365437854-30214-8-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Will Deacon , Christopher Covington To: Marc Zyngier Return-path: Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:48228 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758037Ab3D2Q1X (ORCPT ); Mon, 29 Apr 2013 12:27:23 -0400 Content-Disposition: inline In-Reply-To: <1365437854-30214-8-git-send-email-marc.zyngier@arm.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Apr 08, 2013 at 05:17:09PM +0100, Marc Zyngier wrote: > +static void inject_abt64(struct kvm_vcpu *vcpu, bool is_iabt, unsigned long addr) > +{ > + unsigned long cpsr = *vcpu_cpsr(vcpu); > + int is_aarch32; > + u32 esr = 0; > + > + is_aarch32 = vcpu_mode_is_32bit(vcpu); Minor thing - use bool here to match the function definition? -- Catalin