From: Gleb Natapov <gleb@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>,
kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write
Date: Thu, 2 May 2013 14:00:02 +0300 [thread overview]
Message-ID: <20130502110002.GE22125@redhat.com> (raw)
In-Reply-To: <2D0FA3F3-8324-4B1A-945F-5BE8179CECF0@suse.de>
On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote:
>
> On 02.05.2013, at 09:18, Gleb Natapov wrote:
>
> > On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote:
> >>
> >> On 27.04.2013, at 02:53, Scott Wood wrote:
> >>
> >>> Nobody is actually calling these functions with slots_lock held.
> >>> The srcu read lock, OTOH, is required.
> >>>
> >>> Signed-off-by: Scott Wood <scottwood@freescale.com>
> >>
> >> Marcelo, could you please ack?
> >>
> > Is something in the series depends on this patch? If not this should go
> > directly into kvm.git, not via ppc tree.
>
> If that's easier for you, I'm perfectly fine with that.
>
It really is. In the case of this patch it is not a big deal of course, but it
helps with tracking which changes an architecture code actually depends
on, and what are just generic fixes. When fixes for the common code are
hidden in the middle of a ppc patch set they are easy to miss.
--
Gleb.
next prev parent reply other threads:[~2013-05-02 11:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 0:53 [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions Scott Wood
2013-04-27 0:53 ` [PATCH 2/3] kvm/ppc: Hold srcu lock when calling kvm_io_bus_read/write Scott Wood
2013-05-02 11:22 ` Alexander Graf
2013-04-27 0:53 ` [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write Scott Wood
2013-05-01 23:24 ` Alexander Graf
2013-05-02 7:18 ` Gleb Natapov
2013-05-02 10:53 ` Alexander Graf
2013-05-02 11:00 ` Gleb Natapov [this message]
2013-05-02 11:25 ` Alexander Graf
2013-05-02 0:15 ` [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions Marcelo Tosatti
2013-05-02 0:27 ` Scott Wood
2013-05-02 0:30 ` Scott Wood
2013-05-02 11:20 ` Alexander Graf
2013-05-02 14:37 ` Marcelo Tosatti
2013-05-02 16:47 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502110002.GE22125@redhat.com \
--to=gleb@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox