From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for
 kvm_io_bus_read/write
Date: Thu, 2 May 2013 14:00:02 +0300
Message-ID: <20130502110002.GE22125@redhat.com>
References: <1367024020-14204-1-git-send-email-scottwood@freescale.com>
 <1367024020-14204-3-git-send-email-scottwood@freescale.com>
 <0FF422D3-950C-4089-A964-CDF0B5CC6A24@suse.de>
 <20130502071805.GD22125@redhat.com>
 <2D0FA3F3-8324-4B1A-945F-5BE8179CECF0@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Scott Wood <scottwood@freescale.com>, kvm-ppc@vger.kernel.org,
	"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <2D0FA3F3-8324-4B1A-945F-5BE8179CECF0@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote:
> 
> On 02.05.2013, at 09:18, Gleb Natapov wrote:
> 
> > On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote:
> >> 
> >> On 27.04.2013, at 02:53, Scott Wood wrote:
> >> 
> >>> Nobody is actually calling these functions with slots_lock held.
> >>> The srcu read lock, OTOH, is required.
> >>> 
> >>> Signed-off-by: Scott Wood <scottwood@freescale.com>
> >> 
> >> Marcelo, could you please ack?
> >> 
> > Is something in the series depends on this patch? If not this should go
> > directly into kvm.git, not via ppc tree.
> 
> If that's easier for you, I'm perfectly fine with that.
> 
It really is. In the case of this patch it is not a big deal of course, but it
helps with tracking which changes an architecture code actually depends
on, and what are just generic fixes. When fixes for the common code are
hidden in the middle of a ppc patch set they are easy to miss. 

--
			Gleb.