From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v3 19/32] arm64: KVM: Plug the VGIC Date: Thu, 2 May 2013 15:38:29 +0100 Message-ID: <20130502143828.GE20730@arm.com> References: <1365437854-30214-1-git-send-email-marc.zyngier@arm.com> <1365437854-30214-20-git-send-email-marc.zyngier@arm.com> <20130423230012.GG20569@gmail.com> <5177C559.9070806@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoffer Dall , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Will Deacon , Christopher Covington To: Marc Zyngier Return-path: Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:57870 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759231Ab3EBOjw (ORCPT ); Thu, 2 May 2013 10:39:52 -0400 Content-Disposition: inline In-Reply-To: <5177C559.9070806@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 24, 2013 at 12:43:21PM +0100, Marc Zyngier wrote: > On 24/04/13 00:00, Christoffer Dall wrote: > > On Mon, Apr 08, 2013 at 05:17:21PM +0100, Marc Zyngier wrote: > >> Add support for the in-kernel GIC emulation. The include file > >> is a complete duplicate of the 32bit one - something to fix > >> at one point. > > > > seems like something that should be fixed sooner as opposed to later... > > Is it hard? > > Hard? No. Disgusting? Yes. > > You need to find a common location for the files. Something like > virt/kvm/arm/vgic.h? The x86/ia64 guys already have virt/kvm/ioapic.h as > a (bad) precedent. Probably not that bad, we already have include/linux/irqchip/arm-gic.h, so you could add virt/kvm/arm-vgic.[ch] (or create an arm subdirectory so there will be a tendency to move a lot more in there). -- Catalin