From mboxrd@z Thu Jan  1 00:00:00 1970
From: Will Deacon <will.deacon@arm.com>
Subject: Re: [RFC PATCH 04/11] kvm tools: console: unconditionally output to
 any console
Date: Fri, 3 May 2013 17:09:40 +0100
Message-ID: <20130503160940.GF8256@mudshark.cambridge.arm.com>
References: <1367423416-24640-1-git-send-email-will.deacon@arm.com>
 <1367423416-24640-5-git-send-email-will.deacon@arm.com>
 <CAOJsxLGcZys-WYLg=rBON5iaaiHP6g_w-X3GXfpZz-R5BZtjJA@mail.gmail.com>
 <5183DF86.3040507@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>, Asias He <asias@redhat.com>,
	KVM General <kvm@vger.kernel.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	"anup@brainfault.org" <anup@brainfault.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"pranavkumar@linaro.org" <pranavkumar@linaro.org>,
	Michael Ellerman <michael@ellerman.id.au>
To: Sasha Levin <sasha.levin@oracle.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:59853 "EHLO
	cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S933306Ab3ECQKU (ORCPT
	<rfc822;kvm@vger.kernel.org>); Fri, 3 May 2013 12:10:20 -0400
Content-Disposition: inline
In-Reply-To: <5183DF86.3040507@oracle.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, May 03, 2013 at 05:02:14PM +0100, Sasha Levin wrote:
> On 05/03/2013 05:19 AM, Pekka Enberg wrote:
> > On Wed, May 1, 2013 at 6:50 PM, Will Deacon <will.deacon@arm.com> wrote:
> >> From: Marc Zyngier <Marc.Zyngier@arm.com>
> >>
> >> Kvmtool suppresses any output to a console that has not been elected
> >> as *the* console.
> >>
> >> While this makes sense on the input side (we want the input to be sent
> >> to one console driver only), it seems to be the wrong thing to do on
> >> the output side, as it effectively prevents the guest from switching
> >> from one console to another (think earlyprintk using 8250 to virtio
> >> console).
> >>
> >> After all, the guest *does* poke this device and outputs something
> >> there.
> >>
> >> Just remove the kvm->cfg.active_console test from the output paths.
> >>
> >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >> Signed-off-by: Will Deacon <will.deacon@arm.com>
> > 
> > Seems reasonable. Asias, Sasha?
> > 
> 
> I remember at trying it some time ago but dropped it for a reason I don't
> remember at the moment.
> 
> Can I have the weekend to play with it to try and figure out why?

There's no rush from my point of view (hence the RFC) so take as long as you
need!

Will