From: Gleb Natapov <gleb@redhat.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, agraf@suse.de
Subject: Re: [PATCH] kvm: Add compat_ioctl for device control API
Date: Sun, 5 May 2013 12:16:25 +0300 [thread overview]
Message-ID: <20130505091624.GH22125@redhat.com> (raw)
In-Reply-To: <20130501010045.GA14416@home.buserror.net>
On Tue, Apr 30, 2013 at 08:00:45PM -0500, Scott Wood wrote:
> This API shouldn't have 32/64-bit issues, but VFS assumes it does
> unless told otherwise.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
Applied, thanks.
> ---
> virt/kvm/kvm_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 54a14fa..ee0adad 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2221,6 +2221,9 @@ static int kvm_device_release(struct inode *inode, struct file *filp)
>
> static const struct file_operations kvm_device_fops = {
> .unlocked_ioctl = kvm_device_ioctl,
> +#ifdef CONFIG_COMPAT
> + .compat_ioctl = kvm_device_ioctl,
> +#endif
> .release = kvm_device_release,
> };
>
> --
> 1.7.10.4
--
Gleb.
prev parent reply other threads:[~2013-05-05 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 1:00 [PATCH] kvm: Add compat_ioctl for device control API Scott Wood
2013-05-05 9:16 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130505091624.GH22125@redhat.com \
--to=gleb@redhat.com \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox