From: Gleb Natapov <gleb@redhat.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: mtosatti@redhat.com, yongjun_wei@trendmicro.com.cn, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: add missing misc_deregister() on error in kvm_init()
Date: Sun, 12 May 2013 12:06:58 +0300 [thread overview]
Message-ID: <20130512090658.GF10830@redhat.com> (raw)
In-Reply-To: <CAPgLHd-Ee3BciM5KkS1zNhaNj0qT6ojCksF5+d1-dEkXizJumg@mail.gmail.com>
On Sun, May 05, 2013 at 08:03:40PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing misc_deregister() before return from kvm_init()
> in the debugfs init error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks.
> ---
> virt/kvm/kvm_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index f18013f..3eb4d16 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -3012,6 +3012,7 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align,
>
> out_undebugfs:
> unregister_syscore_ops(&kvm_syscore_ops);
> + misc_deregister(&kvm_dev);
> out_unreg:
> kvm_async_pf_deinit();
> out_free:
--
Gleb.
prev parent reply other threads:[~2013-05-12 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-05 12:03 [PATCH] KVM: add missing misc_deregister() on error in kvm_init() Wei Yongjun
2013-05-12 9:06 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130512090658.GF10830@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox