From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] emulator: add MUL tests
Date: Mon, 20 May 2013 15:32:41 +0300
Message-ID: <20130520123241.GS4725@redhat.com>
References: <1360402345-19976-1-git-send-email-avi.kivity@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi.kivity@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:44061 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755480Ab3ETMco (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 20 May 2013 08:32:44 -0400
Content-Disposition: inline
In-Reply-To: <1360402345-19976-1-git-send-email-avi.kivity@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sat, Feb 09, 2013 at 11:32:25AM +0200, Avi Kivity wrote:
> Signed-off-by: Avi Kivity <avi.kivity@gmail.com>
Applied, thanks.

> ---
>  x86/emulator.c | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/x86/emulator.c b/x86/emulator.c
> index a128e13..96576e5 100644
> --- a/x86/emulator.c
> +++ b/x86/emulator.c
> @@ -583,9 +583,9 @@ static void test_imul(ulong *mem)
>      report("imul rax, mem, imm", a == 0x1D950BDE1D950BC8L);
>  }
>  
> -static void test_div(long *mem)
> +static void test_muldiv(long *mem)
>  {
> -    long a, d;
> +    long a, d, aa, dd;
>      u8 ex = 1;
>  
>      *mem = 0; a = 1; d = 2;
> @@ -598,6 +598,19 @@ static void test_div(long *mem)
>  	 : "+a"(a), "+d"(d), "+q"(ex) : "m"(*mem));
>      report("divq (1)",
>  	   a == 0x1ffffffb1b963b33ul && d == 0x273ba4384ede2ul && !ex);
> +    aa = 0x1111111111111111; dd = 0x2222222222222222;
> +    *mem = 0x3333333333333333; a = aa; d = dd;
> +    asm("mulb %2" : "+a"(a), "+d"(d) : "m"(*mem));
> +    report("mulb mem", a == 0x1111111111110363 && d == dd);
> +    *mem = 0x3333333333333333; a = aa; d = dd;
> +    asm("mulw %2" : "+a"(a), "+d"(d) : "m"(*mem));
> +    report("mulw mem", a == 0x111111111111c963 && d == 0x2222222222220369);
> +    *mem = 0x3333333333333333; a = aa; d = dd;
> +    asm("mull %2" : "+a"(a), "+d"(d) : "m"(*mem));
> +    report("mull mem", a == 0x962fc963 && d == 0x369d036);
> +    *mem = 0x3333333333333333; a = aa; d = dd;
> +    asm("mulq %2" : "+a"(a), "+d"(d) : "m"(*mem));
> +    report("mulq mem", a == 0x2fc962fc962fc963 && d == 0x369d0369d0369d0);
>  }
>  
>  typedef unsigned __attribute__((vector_size(16))) sse128;
> @@ -934,7 +947,7 @@ int main()
>  	test_btc(mem);
>  	test_bsfbsr(mem);
>  	test_imul(mem);
> -	test_div(mem);
> +	test_muldiv(mem);
>  	test_sse(mem);
>  	test_mmx(mem);
>  	test_rip_relative(mem, insn_ram);
> -- 
> 1.8.1.2

--
			Gleb.