From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v4 07/32] arm64: KVM: architecture specific MMU backend Date: Mon, 20 May 2013 17:25:28 +0100 Message-ID: <20130520162528.GI3639@MacBook-Pro.local> References: <1368540840-26750-1-git-send-email-marc.zyngier@arm.com> <1368540840-26750-8-git-send-email-marc.zyngier@arm.com> <20130520155739.GF3639@MacBook-Pro.local> <519A4C9B.8070307@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Will Deacon , "pbonzini@redhat.com" , "gleb@redhat.com" , Christopher Covington To: Marc Zyngier Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:51487 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756425Ab3ETQ0E (ORCPT ); Mon, 20 May 2013 12:26:04 -0400 Content-Disposition: inline In-Reply-To: <519A4C9B.8070307@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 20, 2013 at 05:17:31PM +0100, Marc Zyngier wrote: > On 20/05/13 16:57, Catalin Marinas wrote: > > On Tue, May 14, 2013 at 03:13:35PM +0100, Marc Zyngier wrote: > >> +static inline bool kvm_is_write_fault(unsigned long esr) > >> +{ > >> + unsigned long esr_ec = esr >> ESR_EL2_EC_SHIFT; > > > > Not that it would make much difference but for consistency - we use esr > > as an 'unsigned int' in the arm64 code (only 32-bit needed). > > Indeed. Changing it would require a 32bit patch though, as I'd like to > keep the two code bases in line. > > If you don't mind, I'll queue a patch changing this to "unsigned int" on > both architectures once this is merged. I'm OK if you push the patch afterwards, you can add my reviewed-by on this patch. Reviewed-by: Catalin Marinas