From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Vadim Rozenfeld <vrozenfe@redhat.com>, kvm@vger.kernel.org, pl@dlh.net
Subject: Re: [RFC PATCH v2 1/2] add support for Hyper-V reference time counter
Date: Wed, 22 May 2013 00:32:57 -0300 [thread overview]
Message-ID: <20130522033257.GA16087@amt.cnet> (raw)
In-Reply-To: <20130522032847.GI14287@redhat.com>
On Wed, May 22, 2013 at 06:28:47AM +0300, Gleb Natapov wrote
> > > + case HV_X64_MSR_TIME_REF_COUNT:
> > > r = true;
> > > break;
> > > }
> > > @@ -1827,6 +1829,29 @@ static int set_msr_hyperv_pw(struct kvm_vcpu *vcpu, u32 msr, u64 data)
> > > if (__copy_to_user((void __user *)addr, instructions, 4))
> > > return 1;
> > > kvm->arch.hv_hypercall = data;
> > > + local_irq_disable();
> > > + kvm->arch.hv_ref_count = get_kernel_ns();
> > > + local_irq_enable();
> > > + break;
> >
> > local_irq_disable/local_irq_enable not needed.
> >
> get_kernel_ns has WARN_ON(preemptible()) so at least preempt_disable()
> is needed, but all callers of the function disable interrupts.
OK. Its not necessary to disable interrupts (this is a left over of
kvm_guest_update_time).
next prev parent reply other threads:[~2013-05-22 3:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 7:06 [RFC PATCH v2 0/2] Hyper-V timers Vadim Rozenfeld
2013-05-19 7:06 ` [RFC PATCH v2 1/2] add support for Hyper-V reference time counter Vadim Rozenfeld
2013-05-19 13:47 ` Gleb Natapov
2013-05-19 14:37 ` Paolo Bonzini
2013-05-22 0:46 ` Marcelo Tosatti
2013-05-22 3:28 ` Gleb Natapov
2013-05-22 3:32 ` Marcelo Tosatti [this message]
2013-05-22 3:38 ` Gleb Natapov
2013-05-22 14:31 ` Marcelo Tosatti
2013-05-22 7:32 ` Vadim Rozenfeld
2013-05-22 21:55 ` Paolo Bonzini
2013-05-23 6:17 ` Peter Lieven
2013-05-23 9:54 ` Paolo Bonzini
2013-05-23 10:45 ` Peter Lieven
2013-05-23 12:25 ` Vadim Rozenfeld
2013-05-23 13:18 ` Paolo Bonzini
2013-05-23 13:20 ` Peter Lieven
2013-05-23 13:23 ` Paolo Bonzini
2013-05-23 13:30 ` Peter Lieven
2013-05-23 13:40 ` Paolo Bonzini
2013-05-19 7:06 ` [RFC PATCH v2 2/2] add support for Hyper-V invariant TSC Vadim Rozenfeld
2013-05-22 0:50 ` Marcelo Tosatti
2013-05-22 7:22 ` Vadim Rozenfeld
2013-05-22 21:23 ` Marcelo Tosatti
2013-05-23 6:18 ` Peter Lieven
2013-05-23 9:13 ` Gleb Natapov
2013-05-23 13:35 ` Marcelo Tosatti
2013-05-23 15:14 ` Gleb Natapov
2013-05-24 9:57 ` Vadim Rozenfeld
2013-05-23 12:33 ` Vadim Rozenfeld
2013-05-23 12:44 ` Peter Lieven
2013-05-23 12:45 ` Gleb Natapov
2013-05-23 12:54 ` Vadim Rozenfeld
2013-05-23 9:12 ` Gleb Natapov
2013-05-23 13:53 ` Marcelo Tosatti
2013-05-23 15:31 ` Gleb Natapov
2013-05-24 10:11 ` Vadim Rozenfeld
2013-05-24 19:41 ` Marcelo Tosatti
2013-05-27 12:33 ` Vadim Rozenfeld
2013-05-23 12:21 ` Vadim Rozenfeld
2013-05-23 13:47 ` Marcelo Tosatti
2013-05-24 10:01 ` Vadim Rozenfeld
2013-05-23 16:44 ` Paolo Bonzini
2013-05-24 10:16 ` Vadim Rozenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522033257.GA16087@amt.cnet \
--to=mtosatti@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pl@dlh.net \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox