From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: hjk@hansjkoch.de, gregkh@linuxfoundation.org,
yongjun_wei@trendmicro.com.cn, kvm@vger.kernel.org
Subject: Re: [PATCH] uio/uio_pci_generic: fix error return code in probe()
Date: Thu, 23 May 2013 13:06:56 +0300 [thread overview]
Message-ID: <20130523100656.GA16892@redhat.com> (raw)
In-Reply-To: <CAPgLHd9jg2ehgaX6PjpqfdXEYsTArCyDHy=aB1tg2x_qU70UEQ@mail.gmail.com>
On Thu, May 23, 2013 at 05:36:53PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/uio/uio_pci_generic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
> index 077ae12..d0b508b 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -91,7 +91,8 @@ static int probe(struct pci_dev *pdev,
> gdev->info.handler = irqhandler;
> gdev->pdev = pdev;
>
> - if (uio_register_device(&pdev->dev, &gdev->info))
> + err = uio_register_device(&pdev->dev, &gdev->info);
> + if (err)
> goto err_register;
> pci_set_drvdata(pdev, gdev);
>
prev parent reply other threads:[~2013-05-23 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 9:36 [PATCH] uio/uio_pci_generic: fix error return code in probe() Wei Yongjun
2013-05-23 10:06 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523100656.GA16892@redhat.com \
--to=mst@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=kvm@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox