From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] uio/uio_pci_generic: fix error return code in probe() Date: Thu, 23 May 2013 13:06:56 +0300 Message-ID: <20130523100656.GA16892@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hjk@hansjkoch.de, gregkh@linuxfoundation.org, yongjun_wei@trendmicro.com.cn, kvm@vger.kernel.org To: Wei Yongjun Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61585 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757675Ab3EWKGv (ORCPT ); Thu, 23 May 2013 06:06:51 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 23, 2013 at 05:36:53PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Acked-by: Michael S. Tsirkin > --- > drivers/uio/uio_pci_generic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c > index 077ae12..d0b508b 100644 > --- a/drivers/uio/uio_pci_generic.c > +++ b/drivers/uio/uio_pci_generic.c > @@ -91,7 +91,8 @@ static int probe(struct pci_dev *pdev, > gdev->info.handler = irqhandler; > gdev->pdev = pdev; > > - if (uio_register_device(&pdev->dev, &gdev->info)) > + err = uio_register_device(&pdev->dev, &gdev->info); > + if (err) > goto err_register; > pci_set_drvdata(pdev, gdev); >