From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] kvm: add detail error message when fail to add ioeventfd Date: Mon, 3 Jun 2013 12:27:57 +0300 Message-ID: <20130603092757.GE4725@redhat.com> References: <1369198655-25156-1-git-send-email-akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Amos Kong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26033 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab3FCJ2A (ORCPT ); Mon, 3 Jun 2013 05:28:00 -0400 Content-Disposition: inline In-Reply-To: <1369198655-25156-1-git-send-email-akong@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 22, 2013 at 12:57:35PM +0800, Amos Kong wrote: > I try to hotplug 28 * 8 multiple-function devices to guest with > old host kernel, ioeventfds in host kernel will be exhausted, then > qemu fails to allocate ioeventfds for blk/nic devices. > > It's better to add detail error here. > Applied, thanks. > Signed-off-by: Amos Kong > --- > kvm-all.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 8222729..3d5f7b7 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -813,6 +813,8 @@ static void kvm_mem_ioeventfd_add(MemoryListener *listener, > r = kvm_set_ioeventfd_mmio(fd, section->offset_within_address_space, > data, true, section->size, match_data); > if (r < 0) { > + fprintf(stderr, "%s: error adding ioeventfd: %s\n", > + __func__, strerror(-r)); > abort(); > } > } > @@ -843,6 +845,8 @@ static void kvm_io_ioeventfd_add(MemoryListener *listener, > r = kvm_set_ioeventfd_pio(fd, section->offset_within_address_space, > data, true, section->size, match_data); > if (r < 0) { > + fprintf(stderr, "%s: error adding ioeventfd: %s\n", > + __func__, strerror(-r)); > abort(); > } > } > -- > 1.7.1 -- Gleb.