Re: [PATCH] Test case of emulating multibyte NOP

[Gleb Natapov <gleb@redhat.com>]

On Wed, Jun 05, 2013 at 11:22:19PM +0800, 李春奇 <Arthur Chunqi Li> wrote:
> On Wed, Jun 5, 2013 at 11:17 PM, Gleb Natapov <gleb@redhat.com> wrote:
> > On Wed, Jun 05, 2013 at 11:13:37PM +0800, 李春奇 <Arthur Chunqi Li> wrote:
> >> On Wed, Jun 5, 2013 at 11:11 PM, Gleb Natapov <gleb@redhat.com> wrote:
> >> > On Wed, Jun 05, 2013 at 10:56:54PM +0800, 李春奇 <Arthur Chunqi Li> wrote:
> >> >> Hi Gleb,
> >> >> I generate this mail by git send-email and I think the format is OK.
> >> >>
> >> > But I have not received the email, only this your reply to it.
> >> Maybe the initial mail is in your spam box.
> >>
> > Doubt it. I do not see it in mailing list archive either:
> > http://news.gmane.org/gmane.comp.emulators.kvm.devel
> >
> > What git command line you've used to sent the email?
> git send-email --to kvm@vger.kernel.org --cc pbonzini@redhat.com --cc
> gleb@redhat.com  0001-Test-case-of-emulating-multibyte-NOP.patch
> 
> Should I need to add some smtp options?
> 
You need to configure smtp server. Just like you need to do that for any
other email application.
 
> Arthur
> >
> >> >
> >> >> This is my first try to commit a patch in open source community. Sorry
> >> >> for annoying you guys so much.
> >> >>
> >> >> Thanks,
> >> > No problem.
> >> >
> >> >> Arthur
> >> >>
> >> >> On Wed, Jun 5, 2013 at 10:54 PM, Arthur Chunqi Li <yzt356@gmail.com> wrote:
> >> >> > Add multibyte NOP test case to kvm-unit-tests. This version adds test cases into x86/realmode.c. This can test one of bugs when booting RHEL5.9 64-bit.
> >> >> >
> >> >> > Signed-off-by: Arthur Chunqi Li <yzt356@gmail.com>
> >> >> > ---
> >> >> >  x86/realmode.c |   24 ++++++++++++++++++++++++
> >> >> >  1 file changed, 24 insertions(+)
> >> >> >
> >> >> > diff --git a/x86/realmode.c b/x86/realmode.c
> >> >> > index 981be08..e103ca6 100644
> >> >> > --- a/x86/realmode.c
> >> >> > +++ b/x86/realmode.c
> >> >> > @@ -1504,6 +1504,29 @@ static void test_fninit(void)
> >> >> >         report("fninit", 0, fsw == 0 && (fcw & 0x103f) == 0x003f);
> >> >> >  }
> >> >> >
> >> >> > +static void test_nopl(void)
> >> >> > +{
> >> >> > +       MK_INSN(nopl1, ".byte 0x90\n\r"); // 1 byte nop
> >> >> > +       MK_INSN(nopl2, ".byte 0x66, 0x90\n\r"); // 2 bytes nop
> >> >> > +       MK_INSN(nopl3, ".byte 0x0f, 0x1f, 0x00\n\r"); // 3 bytes nop
> >> >> > +       MK_INSN(nopl4, ".byte 0x0f, 0x1f, 0x40, 0x00\n\r"); // 4 bytes nop
> >> >> > +       MK_INSN(nopl5, ".byte 0x0f, 0x1f, 0x44, 0x00, 0x00\n\r"); // 5 bytes nop
> >> >> > +       MK_INSN(nopl6, ".byte 0x66, 0x0f, 0x1f, 0x44, 0x00, 0x00\n\r"); // 6 bytes nop
> >> >> > +       MK_INSN(nopl7, ".byte 0x0f, 0x1f, 0x80, 0x00, 0x00, 0x00, 0x00\n\r"); // 7 bytes nop
> >> >> > +       MK_INSN(nopl8, ".byte 0x0f, 0x1f, 0x84, 0x00, 0x00, 0x00, 0x00, 0x00\n\r"); // 8 bytes nop
> >> >> > +       MK_INSN(nopl9, ".byte 0x66, 0x0f, 0x1f, 0x84, 0x00, 0x00, 0x00, 0x00, 0x00\n\r"); // 9 bytes nop
> >> >> > +       exec_in_big_real_mode(&insn_nopl1);
> >> >> > +       exec_in_big_real_mode(&insn_nopl2);
> >> >> > +       exec_in_big_real_mode(&insn_nopl3);
> >> >> > +       exec_in_big_real_mode(&insn_nopl4);
> >> >> > +       exec_in_big_real_mode(&insn_nopl5);
> >> >> > +       exec_in_big_real_mode(&insn_nopl6);
> >> >> > +       exec_in_big_real_mode(&insn_nopl7);
> >> >> > +       exec_in_big_real_mode(&insn_nopl8);
> >> >> > +       exec_in_big_real_mode(&insn_nopl9);
> >> >> > +       report("nopl", 0, 1);
> >> >> > +}
> >> >> > +
> >> >> >  void realmode_start(void)
> >> >> >  {
> >> >> >         test_null();
> >> >> > @@ -1548,6 +1571,7 @@ void realmode_start(void)
> >> >> >         test_xlat();
> >> >> >         test_salc();
> >> >> >         test_fninit();
> >> >> > +       test_nopl();
> >> >> >
> >> >> >         exit(0);
> >> >> >  }
> >> >> > --
> >> >> > 1.7.9.5
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Arthur Chunqi Li
> >> >> Department of Computer Science
> >> >> School of EECS
> >> >> Peking University
> >> >> Beijing, China
> >> >
> >> > --
> >> >                         Gleb.
> >>
> >>
> >>
> >> --
> >> Arthur Chunqi Li
> >> Department of Computer Science
> >> School of EECS
> >> Peking University
> >> Beijing, China
> >
> > --
> >                         Gleb.

--
			Gleb.