From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH] kvm tools: fix boot of guests with more than 4gb of ram Date: Mon, 24 Jun 2013 10:05:16 +0100 Message-ID: <20130624090515.GE23779@mudshark.cambridge.arm.com> References: <1372037011-19466-1-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "penberg@kernel.org" , "kvm@vger.kernel.org" To: Sasha Levin Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:65019 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096Ab3FXJFY (ORCPT ); Mon, 24 Jun 2013 05:05:24 -0400 Content-Disposition: inline In-Reply-To: <1372037011-19466-1-git-send-email-sasha.levin@oracle.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 24, 2013 at 02:23:31AM +0100, Sasha Levin wrote: > Commit "kvm tools: virtio: remove hardcoded assumptions > about guest page size" has introduced a bug that prevented > guests with more than 4gb of ram from booting. 4GB of memory?!?! ;) > The issue is that 'pfn' is a 32bit integer, so when multiplying > it by page size to get the actual page will cause an overflow if > the pfn referred to a memory area above 4gb. > > Signed-off-by: Sasha Levin Acked-by: Will Deacon Will