From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v2] kvm-unit-tests : Basic architecture of VMX nested
 test case
Date: Sun, 28 Jul 2013 15:24:08 +0300
Message-ID: <20130728122408.GH11772@redhat.com>
References: <1374769975-9012-1-git-send-email-yzt356@gmail.com>
 <20130728105306.GG11772@redhat.com>
 <CABpY8MKU640S7Pk83pSiMBFYx5=n=kjfx=uFcAwnjARDfot8FA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@web.de>,
	Paolo Bonzini <pbonzini@redhat.com>
To: Arthur Chunqi Li <yzt356@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:9992 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753412Ab3G1MYL (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 28 Jul 2013 08:24:11 -0400
Content-Disposition: inline
In-Reply-To: <CABpY8MKU640S7Pk83pSiMBFYx5=n=kjfx=uFcAwnjARDfot8FA@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Jul 28, 2013 at 08:18:25PM +0800, Arthur Chunqi Li wrote:
> >> +
> >> +#define SEL_NULL_DESC                0x0
> >> +#define SEL_KERN_CODE_64     0x8
> >> +#define SEL_KERN_DATA_64     0x10
> >> +#define SEL_USER_CODE_64     0x18
> >> +#define SEL_USER_DATA_64     0x20
> >> +#define SEL_CODE_32          0x28
> >> +#define SEL_DATA_32          0x30
> >> +#define SEL_CODE_16          0x38
> >> +#define SEL_DATA_16          0x40
> >> +#define SEL_TSS_RUN          0x48
> >> +
> > This need too be move to the common header file.
> Which header file do you think is suitable to contain these selector
> defines? It should correspond to the defines in x86/cstart64.S
> (x86/cstart.S for 32 bit). lib/x86/processor.h may be suitable, but
> this file only contains inline functions now.
> 
They are VM related, so lib/x86/vm.h should be a good place.

--
			Gleb.