Re: [PATCH v2] kvm-unit-tests : Basic architecture of VMX nested test case

Gleb Natapov
2013-07-28T12:24:11Z

On Sun, Jul 28, 2013 at 08:18:25PM +0800, Arthur Chunqi Li wrote:
> >> +
> >> +#define SEL_NULL_DESC 0x0
> >> +#define SEL_KERN_CODE_64 0x8
> >> +#define SEL_KERN_DATA_64 0x10
> >> +#define SEL_USER_CODE_64 0x18
> >> +#define SEL_USER_DATA_64 0x20
> >> +#define SEL_CODE_32 0x28
> >> +#define SEL_DATA_32 0x30
> >> +#define SEL_CODE_16 0x38
> >> +#define SEL_DATA_16 0x40
> >> +#define SEL_TSS_RUN 0x48
> >> +
> > This need too be move to the common header file.
> Which header file do you think is suitable to contain these selector
> defines? It should correspond to the defines in x86/cstart64.S
> (x86/cstart.S for 32 bit). lib/x86/processor.h may be suitable, but
> this file only contains inline functions now.
>
They are VM related, so lib/x86/vm.h should be a good place.

--
Gleb.