From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v5 08/14] nEPT: Redefine EPT-specific link_shadow_page()
Date: Thu, 1 Aug 2013 10:27:35 +0300
Message-ID: <20130801072735.GM7484@redhat.com>
References: <1375282131-9713-1-git-send-email-gleb@redhat.com>
 <1375282131-9713-9-git-send-email-gleb@redhat.com>
 <51FA0D16.1050703@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Jun Nakajima <jun.nakajima@intel.com>,
	Yang Zhang <yang.z.zhang@intel.com>, pbonzini@redhat.com
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35713 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750756Ab3HAH1j (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 1 Aug 2013 03:27:39 -0400
Content-Disposition: inline
In-Reply-To: <51FA0D16.1050703@linux.vnet.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Aug 01, 2013 at 03:24:06PM +0800, Xiao Guangrong wrote:
> On 07/31/2013 10:48 PM, Gleb Natapov wrote:
> > From: Yang Zhang <yang.z.zhang@Intel.com>
> 
> >  		}
> >  	}
> >  	return emulate;
> > diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
> > index 762c904..0d25351 100644
> > --- a/arch/x86/kvm/paging_tmpl.h
> > +++ b/arch/x86/kvm/paging_tmpl.h
> > @@ -555,7 +555,7 @@ static int FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr,
> >  			goto out_gpte_changed;
> > 
> >  		if (sp)
> > -			link_shadow_page(it.sptep, sp);
> > +			link_shadow_page(it.sptep, sp, PTTYPE != PTTYPE_EPT);
> 
> It is better to use "!!PT_GUEST_ACCESSED_MASK" instead? It will be easier when
> we export A/D to guest in the further.
> 
Yes, this is indeed better. It shows better what is going on here. Will
change and add your Reviewed-by.

> Others look good to me.
> 
> Reviewed-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>

--
			Gleb.