From: Andi Kleen <andi@firstfloor.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, Andi Kleen <ak@linux.intel.com>,
gleb@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kvm: Make kvm_rebooting visible
Date: Tue, 6 Aug 2013 00:57:59 +0200 [thread overview]
Message-ID: <20130805225759.GO19750@two.firstfloor.org> (raw)
In-Reply-To: <52002899.6060209@gmail.com>
> > static void kvm_io_bus_destroy(struct kvm_io_bus *bus);
> >
> >-bool kvm_rebooting;
> >+__visible bool kvm_rebooting;
> > EXPORT_SYMBOL_GPL(kvm_rebooting);
>
> How many of these are there kernel wide?
Not very many (at least on x86 allyes) <~10.
Also most users are not exported.
Probably not worth an own macro.
>
> Could you do something like this instead:
>
> DEFINE_AND_EXPORT_GPL(bool, kvm_rebooting);
>
> The definition of DEFINE_AND_EXPORT_GPL(_type, _name) is left as an
> exercise for the reader.
I actually had EXPORT_SYMBOL make things always visible for a long time,
but it prevents optimizing away unused code in very small
non modular configurations. So I switched to separate annotations.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2013-08-05 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 22:12 [PATCH] kvm: Make kvm_rebooting visible Andi Kleen
2013-08-05 22:35 ` David Daney
2013-08-05 22:57 ` Andi Kleen [this message]
2013-08-07 13:20 ` Paolo Bonzini
2013-08-07 14:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805225759.GO19750@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=ddaney.cavm@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox