From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH] ARM: KVM: Simplify tracepoint text Date: Sun, 11 Aug 2013 20:41:49 -0700 Message-ID: <20130812034149.GA5003@cbox> References: <1376019686-19301-1-git-send-email-christoffer.dall@linaro.org> <520698CD.2070904@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, patches@linaro.org To: Sergei Shtylyov Return-path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:58940 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755622Ab3HLDlx (ORCPT ); Sun, 11 Aug 2013 23:41:53 -0400 Received: by mail-pd0-f169.google.com with SMTP id r10so2891425pdi.28 for ; Sun, 11 Aug 2013 20:41:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <520698CD.2070904@cogentembedded.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Aug 10, 2013 at 11:47:25PM +0400, Sergei Shtylyov wrote: > Hello. > > On 08/09/2013 07:41 AM, Christoffer Dall wrote: > > >The tracepoint for kvm_guest_fault was extremely long, make it a > >slightly bit shorter. > > >Signed-off-by: Christoffer Dall > >--- > > arch/arm/kvm/trace.h | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > >diff --git a/arch/arm/kvm/trace.h b/arch/arm/kvm/trace.h > >index a8e73ed..8cbaea2 100644 > >--- a/arch/arm/kvm/trace.h > >+++ b/arch/arm/kvm/trace.h > >@@ -59,10 +59,9 @@ TRACE_EVENT(kvm_guest_fault, > > __entry->ipa = ipa; > > ), > > > >- TP_printk("guest fault at PC %#08lx (hxfar %#08lx, " > >- "ipa %#16llx, hsr %#08lx", > >- __entry->vcpu_pc, __entry->hxfar, > >- __entry->ipa, __entry->hsr) > >+ TP_printk("ipa 0x%llx, hsr 0x%#08lx, hxfar 0x%#08lx, pc 0x%#08lx", > > "0x" and "#" are redundant, they mean the same thing, hexadecimal prefix. > Duh, indeed, nicely spotted. I'll respin. Thanks, -Christoffer