Re: [PATCH 1/2] vhost: Reduce vhost_work_flush() wakeup latency

Bart Van Assche
2013-08-14T15:22:38Z

On 08/14/13 13:37, Michael S. Tsirkin wrote:
> On Wed, Aug 14, 2013 at 09:02:32AM +0200, Bart Van Assche wrote:
>> If the TIF_NEED_RESCHED task flag is set, wake up any vhost_work_flush()
>> waiters before rescheduling instead of after rescheduling.
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Asias He <asias@redhat.com>
>
> Why exactly? It's not like flush needs to be extra fast ...

I'm not worried about how fast a flush is processed either. But I think
this patch is a nice cleanup of the vhost_worker() function. It
eliminates the uninitialized_var() construct and moves the assignment of
"done_seq" below the read of "queue_seq".

Bart.