Re: [PATCH] KVM: mmu: allow page tables to be in read-only slots

Paolo Bonzini
2013-10-14T15:28:54Z

Il 01/09/2013 11:17, Gleb Natapov ha scritto:
> This makes me think are there other places where gfn_to_hva() was
> used, but gfn_to_hva_prot() should have been?
> - kvm_host_page_size() looks incorrect. We never use huge page to map
> read only memory slots currently.
> - kvm_handle_bad_page() also looks incorrect and may cause incorrect
> address to be reported to userspace.
> - kvm_setup_async_pf() also incorrect. Makes all page fault on read
> only slot to be sync.
> - kvm_vm_fault() one looks OK since function assumes write only slots,
> but it is obsolete and should be deleted anyway.
>
> Others in generic and x86 code looks OK, somebody need to check ppc and
> arm code.

PPC is a mess, for s390 I couldn't find a spec. ARM needs to be fixed.
Patches coming...

Paolo